Fix building static libs

Port of microsoft/vcpkg#17506
opengisch · May 22, 2021 · 97b986f · 97b986f
1 parent 047cf7d
commit 97b986f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/include/spatialindex/capi/sidx_export.h b/include/spatialindex/capi/sidx_export.h
@@ -29,7 +29,7 @@
 #pragma once
 
 #ifndef SIDX_C_DLL
-#if defined(_MSC_VER)
+#if defined(_MSC_VER) && defined(SIDX_DLL_EXPORT)
 #  define SIDX_C_DLL     __declspec(dllexport)
 #  define SIDX_DLL     __declspec(dllexport)
 #else

diff --git a/include/spatialindex/tools/Tools.h b/include/spatialindex/tools/Tools.h
@@ -46,7 +46,7 @@
   #ifdef SIDX_DLL_EXPORT
     #define SIDX_DLL __declspec(dllexport)
   #else
-    #define SIDX_DLL __declspec(dllimport)
+    #define SIDX_DLL
   #endif
 
   // Nuke this annoying warning.  See http://www.unknownroad.com/rtfm/VisualStudio/warningC4251.html

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -208,11 +208,12 @@ if(MSVC)
   target_compile_options(spatialindex PRIVATE /wd4068)
   target_compile_options(spatialindex_c PRIVATE /wd4068)
 
-  target_compile_definitions(spatialindex_c PRIVATE -DSIDX_DLL_EXPORT=1)
-  target_compile_definitions(spatialindex PRIVATE -DSIDX_DLL_EXPORT=1)
-  if(NOT WITH_STATIC_SIDX)
-    target_compile_definitions(spatialindex PRIVATE -DSIDX_DLL_IMPORT=1)
-    target_compile_definitions(spatialindex_c PRIVATE -DSIDX_DLL_IMPORT=1)
+ if (BUILD_SHARED_LIBS)
+   target_compile_definitions(${SIDX_C_LIB_NAME} PRIVATE "-DSIDX_DLL_EXPORT=1")
+   target_compile_definitions(${SIDX_LIB_NAME} PRIVATE "-DSIDX_DLL_EXPORT=1")
+ else()
+  target_compile_definitions(spatialindex PRIVATE -DSIDX_DLL_IMPORT=1)
+  target_compile_definitions(spatialindex_c PRIVATE -DSIDX_DLL_IMPORT=1)
   endif()
 endif()