Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

优化BlockingQueueTypeEnum实现 #1025

Closed
lianyiwuming opened this issue Dec 8, 2022 · 1 comment · Fixed by #1032
Closed

优化BlockingQueueTypeEnum实现 #1025

lianyiwuming opened this issue Dec 8, 2022 · 1 comment · Fixed by #1032
Assignees
@lianyiwuming
Labels
type: refactor Code refactoring work
Milestone
1.5.0

Comments

@lianyiwuming
Copy link
Contributor

需求建议

BlockingQueueTypeEnum 枚举类定义了队列的类型，同时也对应了队列的创建方式，所以，建议把队列创建的职责，给到每个枚举类型。这也是 effective java 中的经典范例。

您的功能请求是否与问题有关？

无。刚好看到这个项目了，之前也有类似的想法。所以就进来看看。

描述你想要的功能

如建议描述。  另外，单独对外暴露队列创建工厂，把BlockingQueueTypeEnum作为实现隐藏起来，可能更好。

对此我刚好最近有时间，我会提一个pr。
@pirme pirme added the type: refactor Code refactoring work label Dec 8, 2022
@pirme pirme added this to the 1.5.0 milestone Dec 8, 2022
@pirme
Copy link
Member

pirme commented Dec 8, 2022

Welcome

This was referenced Dec 8, 2022
Closed
Merged
@wulangcode wulangcode mentioned this issue Mar 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lianyiwuming lianyiwuming

Labels
type: refactor Code refactoring work
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

refactor to BlockingQueueTypeEnum lianyiwuming/hippo4j
优化BlockingQueueTypeEnum实现 #1025
2 participants
@lianyiwuming @pirme