Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to BlockingQueueTypeEnum #1032

Merged

Conversation

lianyiwuming
Copy link
Contributor

Fixes #1025

Changes proposed in this pull request:

  • refactor to BlockingQueueTypeEnum. Separate duties to specify enum item. It's a
    classic example in 《effective java》.

Check mailbox configuration when submitting. Contributor Guide

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 27.93% // Head: 27.94% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c7e03b1) compared to base (21f5a12).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1032      +/-   ##
=============================================
+ Coverage      27.93%   27.94%   +0.01%     
  Complexity       691      691              
=============================================
  Files            241      242       +1     
  Lines           5667     5664       -3     
  Branches         513      511       -2     
=============================================
  Hits            1583     1583              
+ Misses          3942     3939       -3     
  Partials         142      142              
Impacted Files Coverage Δ
...common/executor/support/BlockingQueueTypeEnum.java 0.00% <0.00%> (ø)
...4j/common/web/exception/NotSupportedException.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pirme
Copy link
Member

pirme commented Dec 9, 2022

改动逻辑较多,我需要更多的时间 review,请稍等

@lianyiwuming
Copy link
Contributor Author

lianyiwuming commented Dec 9, 2022

改动逻辑较多,我需要更多的时间 review,请稍等

ok. 没有改动原有代码逻辑。主要是增加了泛型支持。

@magestacks magestacks merged commit 209856a into opengoofy:develop Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

优化BlockingQueueTypeEnum实现
3 participants