Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:default fill config #1041

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Conversation

wulangcode
Copy link
Member

Fixes #1040

Changes proposed in this pull request:

Check mailbox configuration when submitting. Contributor Guide

@magestacks
Copy link
Member

我觉得造成 #1040 问题的原因在 cn.hippo4j.config.springboot.starter.support.DynamicThreadPoolPostProcessor#buildExecutorProperties 这个方法里,而不是新创建个获取默认值的方法。

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 27.93% // Head: 27.80% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (bfd5b55) compared to base (9bda143).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1041      +/-   ##
=============================================
- Coverage      27.93%   27.80%   -0.14%     
+ Complexity       691      688       -3     
=============================================
  Files            241      242       +1     
  Lines           5667     5683      +16     
  Branches         513      513              
=============================================
- Hits            1583     1580       -3     
- Misses          3942     3957      +15     
- Partials         142      146       +4     
Impacted Files Coverage Δ
...main/java/cn/hippo4j/rpc/support/ResultHolder.java 57.89% <0.00%> (-42.11%) ⬇️
...va/cn/hippo4j/common/api/ThreadPoolCheckAlarm.java 0.00% <0.00%> (ø)
.../core/plugin/impl/TaskRejectNotifyAlarmPlugin.java 81.81% <0.00%> (+4.04%) ⬆️
...core/plugin/impl/TaskTimeoutNotifyAlarmPlugin.java 100.00% <0.00%> (+10.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wulangcode
Copy link
Member Author

已修改

@magestacks magestacks merged commit d05efb4 into opengoofy:develop Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

线程池参数默认配置与文档描述不符
2 participants