Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复:相同租户不同项目下,相同线程池id无法同时注册问题 #1526

Closed

Conversation

xx-ee
Copy link

@xx-ee xx-ee commented Dec 19, 2023

Fixes #1525
现象:
94bd73d724573ce808aab665add0515f
server端控制台一直报错如下:
image

前提:
数据库config表:只存在1条记录:租户:hudong、项目id:hd-feed-ext-service-test、线程池id:feed-rednum-push-bath
image

步骤:

  1. 启动第一个服务:租户:hudong、项目id:hd-feed-ext-service-test、线程池id:feed-rednum-push-bath,服务启动成功
  2. 启动第一个服务:租户:hudong、项目id:hd-feed-ext-service-dev、线程池id:feed-rednum-push-bath,服务启动失败,如图:
94bd73d724573ce808aab665add0515f

改动点:

  1. 二次检查添加config表信息时,与首次检查查询维度相同:租户、项目id、线程池id

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1e81da1) 34.33% compared to head (b8a96e6) 34.29%.

Files Patch % Lines
...o4j/config/service/biz/impl/ConfigServiceImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1526      +/-   ##
=============================================
- Coverage      34.33%   34.29%   -0.05%     
+ Complexity       849      848       -1     
=============================================
  Files            262      262              
  Lines           5953     5955       +2     
  Branches         561      561              
=============================================
- Hits            2044     2042       -2     
- Misses          3717     3721       +4     
  Partials         192      192              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@magestacks
Copy link
Member

A more detailed test plan is needed, this PR is closed

@magestacks magestacks closed this Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 相同租户、不同项目id、相同线程池id无法同时注册使用
2 participants