Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ts-eslint to v8 #7759

Merged
merged 7 commits into from
Oct 16, 2024
Merged

chore: upgrade ts-eslint to v8 #7759

merged 7 commits into from
Oct 16, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Oct 8, 2024

Problem

Upgrading eslint-related packages #7756, #7757, #7776, #7777 in tandem.

Solution

@typescript-eslint/ban-types is deprecated. Use @typescript-eslint/no-unsafe-function-type. See ban-types docs.

Breaking Changes

  • No - this PR is backwards compatible

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Oct 15, 2024

Datadog Report

Branch report: fix/eslint-v8-upgrade
Commit report: dd79e78
Test service: formsg

✅ 0 Failed, 2789 Passed, 1 Skipped, 5m 53.88s Total duration (6.64s time saved)

Copy link
Contributor

@kevin9foong kevin9foong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@KenLSM KenLSM merged commit 3431b08 into develop Oct 16, 2024
17 of 19 checks passed
@KenLSM KenLSM deleted the fix/eslint-v8-upgrade branch October 16, 2024 02:19
@KenLSM KenLSM mentioned this pull request Oct 20, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants