fix: set limit to 250kb for whitelist #8043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin9foong
force-pushed
the
fix/reduce-whitelist-limit
branch
from
91fe644 to
bf81c71
Compare
Datadog ReportBranch report: ✅ 0 Failed, 555 Passed, 0 Skipped, 1m 5.64s Total duration (5m 49.07s time saved) |
kevin9foong
force-pushed
the
fix/reduce-whitelist-limit
branch
from
bf81c71 to
3088894
Compare
KenLSM
approved these changes
Jan 13, 2025
KenLSM
added a commit
that referenced
this pull request
Jan 14, 2025
* fix(deps): bump libphonenumber-js from 1.11.16 to 1.11.17 in /shared (#8021) Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.11.16 to 1.11.17. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.11.16...v1.11.17) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: mongoose, nanoid packages update (#8000) * chore: update mongoose, dependabot #378 * chore: update react-email-preview/nanoid * chore: update fe/be nanoid * feat(iframe): add frame messaging for paysg (#7979) * feat: update iframe parent on form submission * fix: remove localhost from trusted origins --------- Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com> * fix: only show fixed translations for supported forms (#8038) * fix: default back to english language if form does not support multi-language * fix: remove login translations from being fetched * fix: set limit to 250kb for whitelist (#8043) Co-authored-by: Ken <ken@open.gov.sg> * chore: bump version to v6.174.0 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com> Co-authored-by: Siddarth Nandanahosur Suresh <48427064+siddarth2824@users.noreply.github.com> Co-authored-by: Kevin Foong <55353265+kevin9foong@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The large number of NRICs needed to be whitelisted resulted in two identified issues:
Closes [insert issue #]
Solution
Reduce whitelist limit to 250kB to mitigate and avoid misleading admins on the file size limit from facing repeated issue.
Breaking Changes