Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade axios to 1.6.2 #93

Merged
merged 5 commits into from
Dec 6, 2023
Merged

chore: upgrade axios to 1.6.2 #93

merged 5 commits into from
Dec 6, 2023

Conversation

justynoh
Copy link
Contributor

Problem

Security upgrade for axios to 1.6.2 based on CVE-2023-45857.

Supersedes #92 #89

Solution

Upgrade axios in all usage to 1.6.2.

Breaking Changes

  • No - this PR is backwards compatible

This was referenced Nov 15, 2023
Closed
Closed
KenLSM
KenLSM approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justynoh I've also taken the liberty to:

  1. Merge develop so that we get this fix in
  2. Update several packages (jest, ts-jest, @types/node, typescript) that had caused the build to fail

@justynoh justynoh merged commit a017183 into develop Dec 6, 2023
7 checks passed
@justynoh justynoh deleted the chore/upgrade-axios branch December 6, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenLSM KenLSM KenLSM approved these changes

@wanlingt wanlingt Awaiting requested review from wanlingt

@tshuli tshuli Awaiting requested review from tshuli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justynoh @KenLSM