fix: update Breadcrumb component to new design #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samanthadotdesign
commented
Jul 26, 2024
samanthadotdesign
commented
- Update typography and semantic colour tokens
- Changed underline offset to not cut off at descenders
- Changed chevron to smaller size
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
karrui
changed the title
|
Might need to rebase? Chromatic did not manage to run for this |
seaerchin
reviewed
Jul 30, 2024
packages/components/src/templates/next/components/internal/Breadcrumb/Breadcrumb.tsx
Outdated
Show resolved
Hide resolved
|
Taking over this PR |
karrui
changed the title
dcshzj
approved these changes
Jul 31, 2024
…t to not cut off at descenders. changed chevron to smaller size.
karrui
force-pushed
the
samanthalee/isom-1275-breadcrumbs-styling-change
branch
from
c41116d to
8a325bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.