feat: add initial site edit navbar #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @seaerchin and the rest of your teammates on |
seaerchin
force-pushed
the
feat/site-edit-navbar
branch
from
9c49f37 to
bd6f1be
Compare
dcshzj
approved these changes
Jul 31, 2024
| </BreadcrumbItem> | ||
|
|
||
| <BreadcrumbItem isCurrentPage> | ||
| <BreadcrumbLink href="#">Current page</BreadcrumbLink> |
There was a problem hiding this comment.
question(non-blocking): is this copy supposed to be "Current page"? I suppose we are supposed to display the title here or something?
There was a problem hiding this comment.
yeap it is, checking w designers. lemme merge this PR first and do ^ in a follow up
seaerchin
force-pushed
the
feat/site-edit-navbar
branch
from
bd6f1be to
16ff2a4
Compare
seaerchin
force-pushed
the
feat/site-edit-navbar
branch
from
16ff2a4 to
8de5bb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This pull request refactors the schema and component structure related to the editing experience.
What changed?
editPageSchemato a centralizedschema.tsfile in theediting-experiencefeature.SiteEditNavbarcomponent to improve the navigational structure within the editing experience.PageEditingLayoutto use the newSiteEditNavbarcomponent.How to test?
Why make this change?
To improve code organization, enhance the user interface, and make future maintenance easier.