ISOM-1292: Add publish endpoint #381

harishv7 · 2024-07-28T12:20:34Z

TL;DR

This pull request introduces a publish endpoint and PublishButton component to the AppNavbar to enable page publishing.

What changed?

Relocated AppNavbar to a new folder structure: components/AppNavbar/AppNavbar.tsx.
Added PublishButton component to AppNavbar.
Implemented publish functionality in PublishButton.tsx with page and site parameters from the navigation path.
Added a new API endpoint publishPage to handle the publishing logic and update the database accordingly.
Updated page.router.ts and page.service.ts with publish logic.

Brief description of logic:

Check if there is a draft to be published, if yes, proceed
Fetch the page and the create a new version by incrementing the current version number
Use this newly created versionId to update the existing resource and set the draftBlobId to null

Pending Todos:

Implement trigger of CodeBuild

How to test?

Navigate to the admin dashboard.
Click the new Publish button.
Verify page publication success or failure messages.

Why make this change?

This feature allows users to publish pages directly from the navigation bar, improving the publishing workflow and user experience.

vercel · 2024-07-28T12:20:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
isomer-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 9, 2024 5:01pm

harishv7 · 2024-07-28T12:20:45Z

ISOM-1111: add publishing scripts #421
ISOM-1293: Add CodeBuild logic #382
ISOM-1292: Add publish endpoint #381 👈
add migration for versions #369
update to use bigint for resourceId and blobId #365
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @harishv7 and the rest of your teammates on Graphite

linear · 2024-07-28T12:22:38Z

ISOM-1292 Add endpoint functionality and logic

apps/studio/src/components/AppNavbar/AppNavbar.tsx

apps/studio/src/components/AppNavbar/PublishButton.tsx

apps/studio/src/server/modules/page/page.service.ts

apps/studio/src/server/modules/version/version.service.ts

apps/studio/src/components/AppNavbar/PublishButton.tsx

dcshzj · 2024-08-08T09:41:03Z

apps/studio/src/components/AppNavbar/AppNavbar.tsx

+          {publishButtonProps.showPublish && (
+            <PublishButton
+              pageId={publishButtonProps.pageId}
+              siteId={publishButtonProps.siteId}
+            />
+          )}


question(non-blocking): should the button be completely hidden, or should it be shown but hidden?

Completely hiding might confuse the user as to why they can't publish. I prefer to show but disable and add a Tooltip saying:
"Publish will be enabled if there are unpublished edits"

@sehyunidaaa lmk your thoughts!

Yup agree, it should be shown but disabled! As for the copy, maybe All changes have been published ?

seaerchin

some minor comments, happy to approve after!

apps/studio/src/components/AppNavbar/AppNavbar.tsx

apps/studio/src/components/AppNavbar/PublishButton.tsx

apps/studio/src/server/modules/page/page.router.ts

apps/studio/src/server/modules/version/version.service.ts

seaerchin · 2024-08-08T09:58:51Z

apps/studio/src/server/modules/version/version.service.ts

+  const addedVersion = await db
+    .insertInto("Version")
+    .values({
+      versionNum,


why do callers need to pas in a versionNum? wouldn't we create the version at 0?

A resource has multiple versions -> every publish on the resource will increment its version by 1

Version numbering starts from 1

apps/studio/src/server/modules/version/version.service.ts

seaerchin · 2024-08-08T10:17:34Z

apps/studio/src/server/modules/version/version.service.ts

+    .values({
+      versionNum,
+      resourceId: String(resourceId),
+      blobId: String(blobId),


not directly actionable but how will we utilise this blobId? the reason i'm asking is because this is a reference so even if we publish, the value of the blob itself can still change.

Once published the blob shouldn't change, it will be tied closely to the version. on the page resource, draftBlobId is immediately set to null so any future edits will be captured as a new blob

accidental approval

harishv7 · 2024-08-12T16:44:23Z

Merge activity

Aug 12, 12:44 PM EDT: @harishv7 started a stack merge that includes this pull request via Graphite.
Aug 12, 12:45 PM EDT: @harishv7 merged this pull request with Graphite.

vercel bot deployed to Preview July 28, 2024 12:20 View deployment

This was referenced Jul 28, 2024

update to use bigint for resourceId and blobId #365

Merged

add migration for versions #369

Merged

harishv7 temporarily deployed to staging July 28, 2024 12:20 — with GitHub Actions Inactive

harishv7 changed the title ~~add publish endpoint~~ Add Publish Feature to AppNavbar Jul 28, 2024

harishv7 changed the title ~~Add Publish Feature to AppNavbar~~ ISOM-1292: Add publish endpoint Jul 28, 2024

harishv7 marked this pull request as ready for review July 28, 2024 12:24

harishv7 requested a review from a team as a code owner July 28, 2024 12:24

harishv7 mentioned this pull request Jul 28, 2024

ISOM-1293: Add CodeBuild logic #382

Merged

harishv7 force-pushed the 07-25-add_migration_for_versions branch from 839db7a to 724aeb1 Compare July 29, 2024 05:20

harishv7 force-pushed the 07-28-add_publish_endpoint branch from 7d96701 to 5478fe4 Compare July 29, 2024 05:21

harishv7 temporarily deployed to staging July 29, 2024 05:21 — with GitHub Actions Inactive

vercel bot deployed to Preview July 29, 2024 05:28 View deployment

dcshzj reviewed Jul 29, 2024

View reviewed changes

harishv7 force-pushed the 07-28-add_publish_endpoint branch from 5478fe4 to 3af1c1b Compare July 29, 2024 08:07

harishv7 temporarily deployed to staging July 29, 2024 08:08 — with GitHub Actions Inactive

vercel bot had a problem deploying to Preview July 29, 2024 08:10 Failure

harishv7 marked this pull request as draft July 29, 2024 08:10

harishv7 force-pushed the 07-25-add_migration_for_versions branch from 3c993ca to 428ba73 Compare July 31, 2024 06:46

harishv7 force-pushed the 07-28-add_publish_endpoint branch from 3af1c1b to 50d871a Compare July 31, 2024 06:46

harishv7 temporarily deployed to staging July 31, 2024 06:46 — with GitHub Actions Inactive

vercel bot had a problem deploying to Preview July 31, 2024 06:55 Failure

harishv7 force-pushed the 07-28-add_publish_endpoint branch from 50d871a to ff7ac7d Compare July 31, 2024 07:57

harishv7 temporarily deployed to staging July 31, 2024 07:58 — with GitHub Actions Inactive

vercel bot had a problem deploying to Preview July 31, 2024 08:01 Failure

Base automatically changed from 07-25-add_migration_for_versions to main July 31, 2024 08:15

harishv7 force-pushed the 07-28-add_publish_endpoint branch from ff7ac7d to c150004 Compare July 31, 2024 08:17

harishv7 temporarily deployed to staging August 3, 2024 11:55 — with GitHub Actions Inactive

harishv7 mentioned this pull request Aug 3, 2024

ISOM-1111: add publishing scripts #421

Merged

vercel bot deployed to Preview August 3, 2024 11:58 View deployment

seaerchin requested a review from a team August 8, 2024 06:58

dcshzj approved these changes Aug 8, 2024

View reviewed changes

seaerchin previously approved these changes Aug 8, 2024

View reviewed changes

harishv7 added 11 commits August 9, 2024 23:21

add publish endpoint

f16afcf

address pr comments

68a23be

extract add version to version service

6d373c8

add serializable isolation

2c66664

fix types for db

5afabc6

regen kysely

dc02a6a

refactor publish button

320a76a

use query parse

db064a3

fix imports

eaedc8d

fix readpage endpoint

a7d1326

fix comments

6c858fc

harishv7 force-pushed the 07-28-add_publish_endpoint branch from e1d76ed to 6c858fc Compare August 9, 2024 16:38

harishv7 temporarily deployed to staging August 9, 2024 16:38 — with GitHub Actions Inactive

vercel bot had a problem deploying to Preview August 9, 2024 16:40 Failure

undo changes on appnavbar

bffb7cb

harishv7 temporarily deployed to staging August 9, 2024 16:43 — with GitHub Actions Inactive

vercel bot had a problem deploying to Preview August 9, 2024 16:44 Failure

fix publish button

0a2f4b5

harishv7 temporarily deployed to staging August 9, 2024 16:57 — with GitHub Actions Inactive

vercel bot deployed to Preview August 9, 2024 17:01 View deployment

harishv7 merged commit f06c139 into main Aug 12, 2024
15 of 17 checks passed

harishv7 deleted the 07-28-add_publish_endpoint branch August 12, 2024 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ISOM-1292: Add publish endpoint #381

ISOM-1292: Add publish endpoint #381

harishv7 commented Jul 28, 2024 •

edited

Loading

vercel bot commented Jul 28, 2024 •

edited

Loading

harishv7 commented Jul 28, 2024 •

edited

Loading

linear bot commented Jul 28, 2024

dcshzj Aug 8, 2024

harishv7 Aug 9, 2024

sehyunidaaa Aug 13, 2024

seaerchin left a comment

seaerchin Aug 8, 2024

harishv7 Aug 9, 2024

seaerchin Aug 8, 2024

harishv7 Aug 9, 2024

harishv7 commented Aug 12, 2024 •

edited

Loading

ISOM-1292: Add publish endpoint #381

ISOM-1292: Add publish endpoint #381

Conversation

harishv7 commented Jul 28, 2024 • edited Loading

TL;DR

What changed?

How to test?

Why make this change?

vercel bot commented Jul 28, 2024 • edited Loading

harishv7 commented Jul 28, 2024 • edited Loading

linear bot commented Jul 28, 2024

dcshzj Aug 8, 2024

Choose a reason for hiding this comment

harishv7 Aug 9, 2024

Choose a reason for hiding this comment

sehyunidaaa Aug 13, 2024

Choose a reason for hiding this comment

seaerchin left a comment

Choose a reason for hiding this comment

seaerchin Aug 8, 2024

Choose a reason for hiding this comment

harishv7 Aug 9, 2024

Choose a reason for hiding this comment

seaerchin Aug 8, 2024

Choose a reason for hiding this comment

harishv7 Aug 9, 2024

Choose a reason for hiding this comment

harishv7 commented Aug 12, 2024 • edited Loading

Merge activity

harishv7 commented Jul 28, 2024 •

edited

Loading

vercel bot commented Jul 28, 2024 •

edited

Loading

harishv7 commented Jul 28, 2024 •

edited

Loading

harishv7 commented Aug 12, 2024 •

edited

Loading