Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce discard changes modal #400

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Jul 31, 2024

Problem

We do not have a discard changes warning modal when users close the drawer with pending changes.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible

Features:

  • Add a new discard changes warning modal when the user attempts to close the complex/native/metadata editing drawer when there are differences between the preview and saved states.

Before & After Screenshots

Screenshot 2024-07-31 at 15 41 57

Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:59am

@dcshzj dcshzj merged commit 3058967 into main Jul 31, 2024
16 checks passed
@dcshzj dcshzj deleted the feat/discard-changes-modal branch July 31, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants