feat: update breakpoints for isomer components, prebuild tw when building studio #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
karrui
changed the title
dcshzj
approved these changes
Jul 31, 2024
|
idk why test failing!!!! |
|
isit the github action never build isomer components before using it :O. must be. i debug later |
karrui
force-pushed
the
update_component_breakpoints
branch
from
14c9fbb to
b13509f
Compare
karrui
force-pushed
the
update_component_breakpoints
branch
from
b13509f to
1285eb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if we should call it "desktop" instead of xl. but maybe xl better. who knows.
TL;DR
This update modifies various screen size and max-width configurations across multiple files.
Also updates turbo config to prebuild tw when running dev/build
What changed?
max-w-screen-xlinstead ofmax-w-container.How to test?
Stories
Why make this change?
To be consistent with desktop breakpoint in design.