chore: shift page.list to resource #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @seaerchin and the rest of your teammates on |
seaerchin
force-pushed
the
03-fix-page-list
branch
from
9f59a4e to
9d0201f
Compare
seaerchin
force-pushed
the
02-create-folders
branch
from
15a7c2e to
ad68fab
Compare
seaerchin
force-pushed
the
03-fix-page-list
branch
from
9d0201f to
61ba7a2
Compare
This was referenced Aug 6, 2024
Merged
seaerchin
force-pushed
the
03-fix-page-list
branch
from
61ba7a2 to
c551f1e
Compare
seaerchin
force-pushed
the
02-create-folders
branch
from
aabe893 to
5c50214
Compare
seaerchin
force-pushed
the
03-fix-page-list
branch
from
c551f1e to
8ecb5e1
Compare
seaerchin
force-pushed
the
02-create-folders
branch
from
5c50214 to
e34bcb8
Compare
seaerchin
force-pushed
the
03-fix-page-list
branch
from
8ecb5e1 to
07d72d6
Compare
seaerchin
force-pushed
the
02-create-folders
branch
from
e34bcb8 to
3930a03
Compare
seaerchin
force-pushed
the
03-fix-page-list
branch
from
07d72d6 to
79dc738
Compare
seaerchin
force-pushed
the
02-create-folders
branch
from
3930a03 to
55789c4
Compare
seaerchin
force-pushed
the
03-fix-page-list
branch
from
79dc738 to
0c9a0ec
Compare
seaerchin
force-pushed
the
02-create-folders
branch
from
55789c4 to
0361896
Compare
seaerchin
force-pushed
the
03-fix-page-list
branch
from
0c9a0ec to
b73833e
Compare
seaerchin
force-pushed
the
03-fix-page-list
branch
from
b73833e to
3cf26a2
Compare
we want ot shift to resource as this returns pages + folders also removed references to `page.list` in our codebase (as given by lsp)
seaerchin
force-pushed
the
03-fix-page-list
branch
from
3cf26a2 to
c748e57
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Consolidates the page listing functionality into the resource module and updates related components.
What changed?
page.listcalls withresource.listcalls in various components and modals.resource.router.tsto include thelistprocedure previously inpage.router.ts.listprocedure frompage.router.ts.utils.resource.listinstead ofutils.page.list.How to test?
Why make this change?
This change aims to streamline the codebase by consolidating listing functionalities, reducing redundancy, and improving maintainability.