-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vica integration #982
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 257 Passed, 36 Skipped, 46.82s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly lgtm - i just took a (brief) look at the vica docs linked in slack
// NOTE: not all props will be used even if we passed them in | ||
// as we will override some of them with Isomer's configuration e.g. font-family | ||
// Nevertheless, keeping them here for reference | ||
interface VicaWidgetProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
abit confused - how will we override? i'm assuming the compiled css will have font-family
but how will vica pick it up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can override directly in
isomer/packages/components/src/templates/next/components/internal/Vica/Vica.tsx
Lines 30 to 36 in 25eee45
<div | |
id="webchat" | |
{...props} | |
app-font-family="Inter, system-ui, sans-serif" | |
// NOTE: Clarifying with VICA regarding color scheme | |
// Once confirmed, will override with site's color scheme for consistency | |
/> |
once VICA got back to me, we also ideally want to use the site's color
to prefill this. For now the only props we know we will override what's passed in is font family
Problem
Add integration for VICA
Solution
Breaking Changes
Features:
Refer to this slack message for installation guide: https://opengovproducts.slack.com/archives/C087MUEJAMA/p1736330772752669?thread_ts=1736245461.677389&cid=C087MUEJAMA
note: decided to follow vica's way of specifying the keys and values as will be easier to port over from agency
Tests
note: slightly tricky to test as we will need to get the app-id and app-name from agencies
site
in the Site table