isom-1719 non-prod sites can be indexed by search engine #987
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 257 Passed, 36 Skipped, 47s Total Time |
| export const shouldBlockIndexing = ( | ||
| environment: IsomerPageSchemaType["site"]["environment"], | ||
| ): boolean => { | ||
| return environment === "staging" | ||
| } | ||
|
|
There was a problem hiding this comment.
shuold we make this more restrictive? we might hvae environments that are non-production which shouldn't be indexed also like vapt or uat
There was a problem hiding this comment.
right now we only support production / staging (generated from our infra)
we can make it more generic to return true if it DOES NOT equate to production since we don't know how many non-production sites are there (could have more than staging, vapt, uat in the future too)
WDYT?
There was a problem hiding this comment.
updated in e810697, thanks!
…ngohjw/isom-1719-test-sites-can-be-indexed-by-search-engine
adriangohjw
deleted the
adriangohjw/isom-1719-test-sites-can-be-indexed-by-search-engine
branch
Problem
Closes https://linear.app/ogp/issue/ISOM-1719/test-sites-can-be-indexed-by-search-engine
while staging sites have
disallowinrobots.txt, according to googleSolution
Breaking Changes
Improvements:
shouldBlockIndexingbased on site's environment/page.tsxbased onshouldBlockIndexingTests
trigger a new codebuild, and inspect the HTML. It should/should not have
<meta name="robots" content="noindex">based on the table below