-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLU-337: Allow attachments in postman #821
Open
kevinkim-ogp
wants to merge
29
commits into
develop-v2
Choose a base branch
from
feat/postman-upload-attachment
base: develop-v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 745 Passed, 0 Skipped, 2m 8.84s Total Time 🔻 Code Coverage Decreases vs Default Branch (1)
|
This reverts commit a8194f7.
kevinkim-ogp
force-pushed
the
feat/postman-upload-attachment
branch
from
December 19, 2024 15:34
dd3a98f
to
116db38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users want to upload a fixed file when sending email via Postman.
Solution
Allow uploads at Postman step for users to send a fixed file with every email.
Note: attachments are available for use in all Postman steps of the same Pipe
Features:
Improvements:
toPrettyDateString
function to convertiso
andms
inputs to date stringsFileUpload
component to show as an IconButton or with textBefore & After Screenshots
BEFORE:
AFTER:
Tests
Deploy Notes
GetObjectTagging
New scripts:
packages/backend/src/graphql/__tests__/mutations/delete-from-s3.itest.ts
: tests for functions to delete from s3packages/backend/src/graphql/__tests__/mutations/flow.mock.ts
: mocks to create mock flow and steppackages/backend/src/graphql/__tests__/mutations/generate-presigned-url.itest.ts
: tests for function to generate pre-signed URL to upload files to S3packages/backend/src/graphql/mutations/delete-from-s3.ts
: function to delete files from S3 and corresponding stepspackages/backend/src/graphql/mutations/generate-presigned-url.ts
: function to generate pre-signed URL for uploading file to S3packages/frontend/src/components/AttachmentSuggestions/components/Checkbox.tsx
: component to display attachments as checkboxespackages/frontend/src/components/AttachmentSuggestions/components/Suggestions.tsx
: component to display attachments in same format as variablespackages/frontend/src/components/AttachmentSuggestions/components/TagList.tsx
: component to display selected files as a Tag, with close button to removepackages/frontend/src/components/AttachmentSuggestions/hooks/useAttachmentSelection.ts
: hook to manage attachment selectionpackages/frontend/src/components/AttachmentSuggestions/index.tsx
: component for suggesting attachment variables or upload fixed attachmentspackages/frontend/src/components/AttachmentSuggestions/style.ts
: to manage styles for AttachmentSuggestions-
packages/frontend/src/components/AttachmentSuggestions/utils.ts
: helpers for attachments including file type and size validation, formatters to file size display, reformatting files to correct format for savingpackages/frontend/src/components/SuggestionsWrapper/index.tsx
: generic wrapper for suggestions panelpackages/frontend/src/graphql/mutations/delete-from-s3.ts
: to invoke DeleteFromS3packages/frontend/src/graphql/mutations/generate-presigned-url.ts
: to callpackages/frontend/src/hooks/useS3Operations.ts
: hook to perform upload and delete from S3packages/frontend/src/theme/components/Checkbox.ts
: set style for CheckboxNew dependencies:
@aws-sdk/s3-request-presigner
: to generate pre-signed URL for uploading attachments to S3