Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove postman old credentials #839

Draft
wants to merge 1 commit into
base: develop-v2
Choose a base branch
from
Draft

chore: remove postman old credentials #839

wants to merge 1 commit into from
+4 −57

Conversation

m0nggh
Copy link
Contributor

@m0nggh m0nggh commented Dec 31, 2024

Problem

After migrating over to the new postman credentials: info@plumber.gov.sg, the old ones are not needed anymore.

Solution

Remove the LD flag, and old credentials

TODOs

  • Remove the env variables and deploy to UAT/staging to test it works
  • Remove env variable for prod before deploying to prod
  • Remove LD flag once deployed to prod

Tests

  • OTP emails can be received from the correct email
  • Emails can be sent from the postman action

@m0nggh m0nggh requested a review from a team as a code owner December 31, 2024 04:52
@datadog-opengovsg
Copy link

Datadog Report

Branch report: chore/remove-postman-email-flag
Commit report: 751789f
Test service: plumber

✅ 0 Failed, 733 Passed, 0 Skipped, 2m 4.26s Total Time
➡️ Test Sessions change in coverage: 1 no change

@m0nggh m0nggh marked this pull request as draft December 31, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@m0nggh