fix: prevent campaign names from causing dashboard rows to overflow #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user duplicates a campaign, then duplicates the duplicate, and does it over and over again, the resulting campaign name becomes something like "Copy of Copy of Copy of Copy of ..." This is pretty ridiculous, and doesn't really make sense to have. All these campaigns are really just similar copies of the original campaign anyway. Hence, only prepend "Copy of " if the campaign name doesn't already have it.
lamkeewei
approved these changes
Apr 26, 2021
This was referenced Apr 28, 2021
Closed
Closed
Merged
Merged
lamkeewei
added a commit
that referenced
this pull request
May 5, 2021
* develop: refactor: use shared function to initialize models (#1172) chore: setup scaffolding for backend tests (#940) 1.23.0 fix(frontend): fix frontend test flakiness (#1162) fix: update successful delivery status only if error does not exist (#1150) chore: upgrade dependencies (#1153) feat: add unit tests for error states in critical workflows (#1118) feat: support whitelisting domains through `agencies` table (#1141) feat: add tests for happy paths in critical workflows (#1110) fix: prevent campaign names from causing dashboard rows to overflow (#1147) fix(email): Fix SendGrid fallback integration (#1026)
lamkeewei
added a commit
that referenced
this pull request
May 5, 2021
* develop: feat: refactor msg template components; add telegram character limit (#1148) refactor: use shared function to initialize models (#1172) chore: setup scaffolding for backend tests (#940) 1.23.0 fix(frontend): fix frontend test flakiness (#1162) fix: update successful delivery status only if error does not exist (#1150) chore: upgrade dependencies (#1153) feat: add unit tests for error states in critical workflows (#1118) feat: support whitelisting domains through `agencies` table (#1141) feat: add tests for happy paths in critical workflows (#1110) fix: prevent campaign names from causing dashboard rows to overflow (#1147)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is a minor design issue I noticed during testing:
A particularly long campaign name causes the dashboard table to overflow its container. This doesn't look very good.
Solution
Improvements:
Copy ofto campaign names which don't already have it (explanation in commit 6a3db9a)Bug Fixes:
Before & After Screenshots
BEFORE:
Before screenshots
AFTER:
After screenshots
Tests
Duplicating a duplicated campaign should not prepend
Copy ofto the campaign's nameCopy ofat the start of its name.Copy ofto the new campaign's name.Table should not overflow the container
Deploy Notes
No deploy notes.
Todo
Copy ofprepending functionality works as intended?