Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github-actions): run all tests on PR to develop #1476

Merged
merged 4 commits into from
Apr 18, 2022

Conversation

stanleynguyen
Copy link
Contributor

@stanleynguyen stanleynguyen commented Apr 8, 2022

Resolves #1401
Pending #1475 to run detect-secrets during CI

No-longer-valid test cases (removed from frontend-test) (needs help from @lamkeewei to confirm):
- protected email › displays an error if the subject contains extraneous invalid params (Reason: params are only evaluated at the upload CSV step, not at the template creation)
- protected email › displays an error if the subject contains extraneous invalid params (same as above)
- protected email › displays an error if the body contains extraneous invalid params (same as above)

@stanleynguyen stanleynguyen marked this pull request as draft April 8, 2022 08:13
@stanleynguyen stanleynguyen force-pushed the ci/lint-and-test branch 10 times, most recently from d8b3d58 to 68a8c87 Compare April 13, 2022 04:25
@stanleynguyen stanleynguyen marked this pull request as ready for review April 13, 2022 05:00
@stanleynguyen stanleynguyen force-pushed the ci/lint-and-test branch 2 times, most recently from 108a5b2 to 7e866ba Compare April 13, 2022 08:39
@lamkeewei
Copy link
Contributor

@stanleynguyen for protected email, you can only use {{protectedlink}} or {{recipient}} in your cover message template.

@stanleynguyen
Copy link
Contributor Author

Ready for review @prestonlimlianjie @lamkeewei

Copy link
Contributor

@prestonlimlianjie prestonlimlianjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stanleynguyen stanleynguyen merged commit 3d4199a into develop Apr 18, 2022
@stanleynguyen stanleynguyen deleted the ci/lint-and-test branch April 18, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run unit and integration tests on CI
3 participants