Bugs v1.1 (#75) #76
Bugs v1.1 (#75) #76
Conversation
Deploying with
|
| Latest commit: |
96c0c6e
|
| Status: | 🚫 Build failed. |
| <script type="text/javascript"> | ||
| var pathSegmentsToKeep = 1 | ||
|
|
||
| var l = window.location | ||
| l.replace( | ||
| l.protocol + | ||
| '//' + | ||
| l.hostname + | ||
| (l.port ? ':' + l.port : '') + | ||
| l.pathname | ||
| .split('/') | ||
| .slice(0, 1 + pathSegmentsToKeep) | ||
| .join('/') + | ||
| '/?/' + | ||
| l.pathname.slice(1).split('/').slice(pathSegmentsToKeep).join('/').replace(/&/g, '~and~') + | ||
| (l.search ? '&' + l.search.slice(1).replace(/&/g, '~and~') : '') + | ||
| l.hash | ||
| ) |
There was a problem hiding this comment.
Hey @hadarhubara10
Can you please explain what is going on here?
There was a problem hiding this comment.
For the 404 bug, here is the solution from github - anitab-org/stem-diverse-tv-cms#48 (comment).
| (function(l) { | ||
| if (l.search[1] === '/' ) { | ||
| var decoded = l.search.slice(1).split('&').map(function(s) { | ||
| return s.replace(/~and~/g, '&') | ||
| }).join('?'); | ||
| window.history.replaceState(null, null, | ||
| l.pathname.slice(0, -1) + decoded + l.hash | ||
| ); | ||
| } | ||
| }(window.location)) |
There was a problem hiding this comment.
Same question here, actually. Why is this code necessary?
There was a problem hiding this comment.
same for the 404 bug, here is the solution from github - anitab-org/stem-diverse-tv-cms#48 (comment).
| const [open, setOpen] = useState<boolean>(true) | ||
| const dispatch = useAppDispatch() | ||
|
|
||
| useEffect(() => { | ||
| setToken('') | ||
| setHashes({}) | ||
| setLocalMintAmount('') | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| setFunds('0.5') |
There was a problem hiding this comment.
The recommended amount and default value of the fund
| @@ -15,7 +15,7 @@ interface IProps { | |||
| export default function Funder({ success }: IProps) { | |||
| const [hashes, setHashes] = useLocalStorage<Hashes>('hashes', {}) | |||
| const [listen, setListen] = useState(false) | |||
| const [funds, setFunds] = useState<number>(0.5) | |||
| const [funds, setFunds] = useLocalStorage<string>('funds', '0.5') | |||
There was a problem hiding this comment.
General question - I see we store a lot of things in the local storage. When do we clean it up? Will there be an issue if the user wants to register two relays in a row?
There was a problem hiding this comment.
This will not be a problem, this is cleaned up in the success modal
No description provided.