Flickering test fix #323
Merged
Flickering test fix #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forshtat
reviewed
Apr 17, 2020
test/RelayHubPenalizations.test.ts
Outdated
Comment on lines
435
to
436
| // const signature = `0x${'00'.repeat(32 - tx.r.length) + tx.r.toString('hex')}${'00'.repeat( | ||
| // 32 - tx.s.length) + tx.s.toString('hex')}${v.toString(16)}` |
test/RelayHubPenalizations.test.ts
Outdated
Comment on lines
377
to
380
| // This doesn't work since they are "read only" | ||
| // transaction.r = Buffer.concat([Buffer.from('00'.repeat(32 - transaction.r.length),'hex'), transaction.r]) | ||
| // transaction.s = Buffer.concat([Buffer.from('00'.repeat(32 - transaction.s.length),'hex'), transaction.s]) | ||
| // This does work, but is ugly and involves knowing the implementation details of ethereumjs-tx.Transaction class |
forshtat
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blast from the past: ethereumjs/ethereumjs-monorepo#710
Alex and I already discussed this issue and commented on their open issue in their repo, which still exists.