Update rules.js #287
Open
Update rules.js #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fix has been working for me for months now.....
|
Thank you! Similar to the OH repos, I've been requiring sign-offs on commits... https://www.openhab.org/docs/developer/contributing.html#sign-your-work. You can either setup a local repo and use git to amend your commit, or close this PR and submit another (through the web) and include... Signed-off-by: Joe Smith joe.smith@email.com ... at the bottom of the commit message. |
volfan6415
added a commit
to volfan6415/openhab-helper-libraries
that referenced
this pull request
Feb 11, 2021
This code makes some changes to the rule generation which enables the use of the conditions. I have been running this code for almost 2 years now without any issues. I don't think this was implemented in the main fork but i made a pull requests on them. see openhab-scripters#287 and openhab-scripters#286 respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix has been working for me for months now.....
This breaks out the rule change part from #219