[ipcamera] Fix hikvision camera going offline when requesting I/O status

It might happen that a IP camera (Hikvision) replies with HTTP 401 but does not add a WWW-Authenticate header for our reconnect logic while we request the status of it's I/O ports. This fix offers an advanced config option to deactivate requesting the I/O ports. Fixes #15413 Signed-off-by: Stefan Triller <github@stefantriller.de>
openhab · Dec 9, 2023 · 13ffd5c · 13ffd5c
1 parent 2de14d2
commit 13ffd5c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/...ab.binding.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/CameraConfig.java b/...ab.binding.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/CameraConfig.java
@@ -30,6 +30,7 @@ public class CameraConfig {
     public boolean useToken = true;
     private int onvifMediaProfile;
     private int pollTime;
+    private boolean hasExternalAlarmInputs = false;
     private String ffmpegInput = "";
     private String snapshotUrl = "";
     private String mjpegUrl = "";
@@ -138,6 +139,10 @@ public int getPollTime() {
         return pollTime;
     }
 
+    public boolean getHasExternalAlarmInputs() {
+        return hasExternalAlarmInputs;
+    }
+
     public int getOnvifPort() {
         return onvifPort;
     }

diff --git a/...ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/handler/IpCameraHandler.java b/...ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/handler/IpCameraHandler.java
@@ -1700,7 +1700,7 @@ public void initialize() {
                 if (snapshotUri.isEmpty()) {
                     snapshotUri = "/ISAPI/Streaming/channels/" + cameraConfig.getNvrChannel() + "01/picture";
                 }
-                if (lowPriorityRequests.isEmpty()) {
+                if (cameraConfig.getHasExternalAlarmInputs() && lowPriorityRequests.isEmpty()) {
                     lowPriorityRequests.add("/ISAPI/System/IO/inputs/" + cameraConfig.getNvrChannel() + "/status");
                 }
                 break;

diff --git a/bundles/org.openhab.binding.ipcamera/src/main/resources/OH-INF/thing/thing-types.xml b/bundles/org.openhab.binding.ipcamera/src/main/resources/OH-INF/thing/thing-types.xml
@@ -1986,6 +1986,14 @@
 				<advanced>true</advanced>
 			</parameter>
 
+			<parameter name="hasExternalAlarmInputs" type="boolean" groupName="Settings">
+				<label>Has External Alarm Inputs</label>
+				<description>Select if your camera supports external alarm inputs (i.e. for externally connected PIR sensors, etc.).
+				</description>
+				<default>false</default>
+				<advanced>true</advanced>
+			</parameter>
+
 		</config-description>
 	</thing-type>