[asuswrt] Apply suggestions from code review

Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: Christian Wild <christian@wildclan.de>
openhab · Dec 2, 2022 · 18368a2 · 18368a2
1 parent c17f5ca
commit 18368a2
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 11 deletions.
diff --git a/bom/openhab-addons/pom.xml b/bom/openhab-addons/pom.xml
@@ -116,6 +116,11 @@
       <artifactId>org.openhab.binding.astro</artifactId>
       <version>${project.version}</version>
     </dependency>
+    <dependency>
+      <groupId>org.openhab.addons.bundles</groupId>
+      <artifactId>org.openhab.binding.asuswrt</artifactId>
+      <version>${project.version}</version>
+    </dependency>
     <dependency>
       <groupId>org.openhab.addons.bundles</groupId>
       <artifactId>org.openhab.binding.atlona</artifactId>

diff --git a/bundles/org.openhab.binding.asuswrt/README.md b/bundles/org.openhab.binding.asuswrt/README.md
@@ -4,7 +4,7 @@ This binding adds support to control get informations from ASUS-Router (Copyrigh
 
 ## Supported Things
 
-Binding supports ASUS-Router with AsusWRT or -AsusWRT-Merlin Firmware.
+This binding supports ASUS routers with Asuswrt or [Asuswrt-Merlin](https://www.asuswrt-merlin.net/) firmware.
 Firmware 5.x.x (some DSL models) is NOT supported (not AsusWRT).
 
 | ThingType     | Name       | Descripion                              |

diff --git a/bundles/org.openhab.binding.asuswrt/src/main/feature/feature.xml b/bundles/org.openhab.binding.asuswrt/src/main/feature/feature.xml
@@ -2,7 +2,7 @@
 <features name="org.openhab.binding.asuswrt-${project.version}" xmlns="http://karaf.apache.org/xmlns/features/v1.4.0">
 	<repository>mvn:org.openhab.core.features.karaf/org.openhab.core.features.karaf.openhab-core/${ohc.version}/xml/features</repository>
 
-	<feature name="openhab-binding-asuswrt" description="asuswrt Binding" version="${project.version}">
+	<feature name="openhab-binding-asuswrt" description="Asuswrt Binding" version="${project.version}">
 		<feature>openhab-runtime-base</feature>
 		<bundle start-level="80">mvn:org.openhab.addons.bundles/org.openhab.binding.asuswrt/${project.version}</bundle>
 	</feature>

diff --git a/bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/binding/binding.xml b/bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/binding/binding.xml
@@ -4,6 +4,6 @@
 	xsi:schemaLocation="https://openhab.org/schemas/binding/v1.0.0 https://openhab.org/schemas/binding-1.0.0.xsd">
 
 	<name>Asuswrt Binding</name>
-	<description>Binding for your asus routers (asuswrt / asuswrt-merlin only)</description>
+	<description>Binding for ASUS routers (Asuswrt / Asuswrt-Merlin only)</description>
 
 </binding:binding>
diff --git a/bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/i18n/asuswrt.properties b/bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/i18n/asuswrt.properties
@@ -1,7 +1,7 @@
 # binding
 
 binding.asuswrt.name = Asuswrt Binding
-binding.asuswrt.description = Binding for your asus routers (asuswrt / asuswrt-merlin only)
+binding.asuswrt.description = Binding for ASUS routers (Asuswrt / Asuswrt-Merlin only)
 
 # thing types
 

diff --git a/...rol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlHandlerFactory.java b/...rol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlHandlerFactory.java
@@ -56,8 +56,7 @@ public class TapoControlHandlerFactory extends BaseThingHandlerFactory {
     @Activate
     public TapoControlHandlerFactory() {
         // create new httpClient
-        SslContextFactory.Client sslContextFactory = new SslContextFactory.Client();
-        httpClient = new HttpClient(sslContextFactory);
+        httpClient = new HttpClient(new SslContextFactory.Client());
         httpClient.setFollowRedirects(false);
         httpClient.setMaxConnectionsPerDestination(HTTP_MAX_CONNECTIONS);
         httpClient.setMaxRequestsQueuedPerDestination(HTTP_MAX_QUEUED_REQUESTS);

diff --git a/bundles/pom.xml b/bundles/pom.xml
@@ -187,7 +187,6 @@
     <module>org.openhab.binding.jablotron</module>
     <module>org.openhab.binding.jeelink</module>
     <module>org.openhab.binding.jellyfin</module>
-    <module>org.openhab.binding.juicenet</module>
     <module>org.openhab.binding.kaleidescape</module>
     <module>org.openhab.binding.keba</module>
     <module>org.openhab.binding.km200</module>
@@ -218,7 +217,6 @@
     <module>org.openhab.binding.max</module>
     <module>org.openhab.binding.mcd</module>
     <module>org.openhab.binding.mcp23017</module>
-    <module>org.openhab.binding.meater</module>
     <module>org.openhab.binding.mecmeter</module>
     <module>org.openhab.binding.melcloud</module>
     <module>org.openhab.binding.mercedesme</module>
@@ -306,7 +304,6 @@
     <module>org.openhab.binding.pushover</module>
     <module>org.openhab.binding.pushsafer</module>
     <module>org.openhab.binding.qbus</module>
-    <module>org.openhab.binding.qolsysiq</module>
     <module>org.openhab.binding.radiothermostat</module>
     <module>org.openhab.binding.regoheatpump</module>
     <module>org.openhab.binding.revogi</module>
@@ -368,7 +365,6 @@
     <module>org.openhab.binding.tibber</module>
     <module>org.openhab.binding.tivo</module>
     <module>org.openhab.binding.touchwand</module>
-    <module>org.openhab.binding.tplinkrouter</module>
     <module>org.openhab.binding.tplinksmarthome</module>
     <module>org.openhab.binding.tr064</module>
     <module>org.openhab.binding.tradfri</module>
@@ -655,4 +651,4 @@
     </profile>
   </profiles>
 
-</project>
+</project>