Skip to content

Commit

Permalink
[tesla] Remove the minimum 5A charge current limit
Browse files Browse the repository at this point in the history
While the app can't go lower than 5A, the API allows setting values down
to 0A, and at least going to 2-3A can make sense if you want to put
excess solar power into the car without also drawing some from the grid.

Due to the overhead this causes it can be wasteful, so keep logging the
warning about going below 5A. Leave the limiting/validation of values
>32A up to the API, not this addon.

Signed-off-by: Ulrich Spörlein <uspoerlein@gmail.com>
  • Loading branch information
uqs committed Oct 6, 2023
1 parent 0157ebf commit 232caaa
Showing 1 changed file with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,8 @@ public void handleCommand(ChannelUID channelUID, Command command) {
}
}
if (amps != null) {
if (amps < 5 || amps > 32) {
logger.warn("Charging amps can only be set in a range of 5-32A, but not to {}A.", amps);
return;
if (amps < 5) {
logger.warn("Charging amps should be set higher than 5A to avoid excessive losses.");
}
setChargingAmps(amps);
}
Expand Down

0 comments on commit 232caaa

Please sign in to comment.