[picotts] Add null annotations

Signed-off-by: Wouter Born <github@maindrain.net>
openhab · Mar 26, 2021 · 88f0e24 · 88f0e24
1 parent 6e1119a
commit 88f0e24
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 8 deletions.
diff --git a/...ab.voice.picotts/src/main/java/org/openhab/voice/picotts/internal/PicoTTSAudioStream.java b/...ab.voice.picotts/src/main/java/org/openhab/voice/picotts/internal/PicoTTSAudioStream.java
@@ -18,6 +18,8 @@
 import java.io.IOException;
 import java.io.InputStream;
 
+import org.eclipse.jdt.annotation.NonNullByDefault;
+import org.eclipse.jdt.annotation.Nullable;
 import org.openhab.core.audio.AudioException;
 import org.openhab.core.audio.AudioFormat;
 import org.openhab.core.audio.AudioStream;
@@ -29,14 +31,15 @@
  *
  * @author Florian Schmidt - Initial Contribution
  */
+@NonNullByDefault
 class PicoTTSAudioStream extends FixedLengthAudioStream {
     private final Voice voice;
     private final String text;
     private final AudioFormat audioFormat;
     private final InputStream inputStream;
 
     private long length;
-    private File file;
+    private @Nullable File file;
 
     public PicoTTSAudioStream(String text, Voice voice, AudioFormat audioFormat) throws AudioException {
         this.text = text;
@@ -57,7 +60,8 @@ private InputStream createInputStream() throws AudioException {
         try {
             Process process = Runtime.getRuntime().exec(command);
             process.waitFor();
-            file = new File(outputFile);
+            File file = new File(outputFile);
+            this.file = file;
             this.length = file.length();
             return getFileInputStream(file);
         } catch (IOException e) {
@@ -68,9 +72,6 @@ private InputStream createInputStream() throws AudioException {
     }
 
     private InputStream getFileInputStream(File file) throws AudioException {
-        if (file == null) {
-            throw new IllegalArgumentException("file must not be null");
-        }
         if (file.exists()) {
             try {
                 return new FileInputStream(file);
@@ -119,6 +120,7 @@ public long length() {
 
     @Override
     public InputStream getClonedStream() throws AudioException {
+        File file = this.file;
         if (file != null) {
             return getFileInputStream(file);
         } else {

diff --git a/...penhab.voice.picotts/src/main/java/org/openhab/voice/picotts/internal/PicoTTSService.java b/...penhab.voice.picotts/src/main/java/org/openhab/voice/picotts/internal/PicoTTSService.java
@@ -18,6 +18,8 @@
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
+import org.eclipse.jdt.annotation.NonNullByDefault;
+import org.eclipse.jdt.annotation.Nullable;
 import org.openhab.core.audio.AudioException;
 import org.openhab.core.audio.AudioFormat;
 import org.openhab.core.audio.AudioStream;
@@ -30,6 +32,7 @@
  * @author Florian Schmidt - Initial Contribution
  */
 @Component
+@NonNullByDefault
 public class PicoTTSService implements TTSService {
     private final Set<Voice> voices = Stream
             .of(new PicoTTSVoice("de-DE"), new PicoTTSVoice("en-US"), new PicoTTSVoice("en-GB"),
@@ -51,8 +54,8 @@ public Set<AudioFormat> getSupportedFormats() {
 
     @Override
     public AudioStream synthesize(String text, Voice voice, AudioFormat requestedFormat) throws TTSException {
-        if (text == null || text.isEmpty()) {
-            throw new TTSException("The passed text can not be null or empty");
+        if (text.isEmpty()) {
+            throw new TTSException("The passed text can not be empty");
         }
 
         if (!this.voices.contains(voice)) {
@@ -80,7 +83,7 @@ public String getId() {
     }
 
     @Override
-    public String getLabel(Locale locale) {
+    public String getLabel(@Nullable Locale locale) {
         return "PicoTTS";
     }
 }
diff --git a/....openhab.voice.picotts/src/main/java/org/openhab/voice/picotts/internal/PicoTTSVoice.java b/....openhab.voice.picotts/src/main/java/org/openhab/voice/picotts/internal/PicoTTSVoice.java
@@ -14,13 +14,15 @@
 
 import java.util.Locale;
 
+import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.openhab.core.voice.Voice;
 
 /**
  * Implementation of the Voice interface for PicoTTS
  *
  * @author Florian Schmidt - Initial Contribution
  */
+@NonNullByDefault
 public class PicoTTSVoice implements Voice {
     private final String languageTag;