Configurable refreshinterval (#17523)

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
openhab · Oct 11, 2024 · 9d97fe4 · 9d97fe4
1 parent 989093c
commit 9d97fe4
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 6 deletions.
diff --git a/bundles/org.openhab.binding.omnikinverter/README.md b/bundles/org.openhab.binding.omnikinverter/README.md
@@ -13,11 +13,12 @@ No autodiscovery available
 
 ## Thing Configuration
 
-| Config   | Description                                                                                                                    | type    | Default   |
-| :------- | :------------                                                                                                                  | :-----  | :-------- |
-| hostname | The hostname or ip through which the inverter can be accessed                                                                  | string  | n/a       |
-| port     | TCP port through which the inverter listens on for incoming connections                                                        | integer | 8899      |
-| serial   | The serial of the wifi module. The Wifi module's SSID contains the number. This is the numerical part only, i.e. without _AP__ | integer | n/a       |
+| Config          | Description                                                                                                                    | type    | Default |
+|:----------------|:-------------------------------------------------------------------------------------------------------------------------------|:--------|:--------|
+| hostname        | The hostname or ip through which the inverter can be accessed                                                                  | string  | n/a     |
+| port            | TCP port through which the inverter listens on for incoming connections                                                        | integer | 8899    |
+| serial          | The serial of the wifi module. The Wifi module's SSID contains the number. This is the numerical part only, i.e. without _AP__ | integer | n/a     |
+| refreshInterval | Interval the device is polled in seconds.                                                                                      | integer | 10      |
 
 ## Channels
 

diff --git a/.../src/main/java/org/openhab/binding/omnikinverter/internal/OmnikInverterConfiguration.java b/.../src/main/java/org/openhab/binding/omnikinverter/internal/OmnikInverterConfiguration.java
@@ -24,4 +24,5 @@ public class OmnikInverterConfiguration {
     public String hostname = "";
     public int port;
     public int serial;
+    public int refreshInterval = 10;
 }
diff --git a/...rc/main/java/org/openhab/binding/omnikinverter/internal/handler/OmnikInverterHandler.java b/...rc/main/java/org/openhab/binding/omnikinverter/internal/handler/OmnikInverterHandler.java
@@ -74,7 +74,7 @@ public void initialize() {
 
         inverter = new OmnikInverter(config.hostname, config.port, config.serial);
         updateStatus(ThingStatus.UNKNOWN);
-        pollJob = scheduler.scheduleWithFixedDelay(this::updateData, 0, 10, TimeUnit.SECONDS);
+        pollJob = scheduler.scheduleWithFixedDelay(this::updateData, 0, config.refreshInterval, TimeUnit.SECONDS);
     }
 
     @Override

diff --git a/...org.openhab.binding.omnikinverter/src/main/resources/OH-INF/i18n/omnikinverter.properties b/...org.openhab.binding.omnikinverter/src/main/resources/OH-INF/i18n/omnikinverter.properties
@@ -50,6 +50,8 @@ thing-type.config.omnikinverter.omnik.hostname.label = Hostname
 thing-type.config.omnikinverter.omnik.hostname.description = The hostname or IP of the Omnik Inverter
 thing-type.config.omnikinverter.omnik.port.label = Port
 thing-type.config.omnikinverter.omnik.port.description = The TCP port of the Omnik inverter, usually 8899
+thing-type.config.omnikinverter.omnik.refreshInterval.label = Refresh Interval
+thing-type.config.omnikinverter.omnik.refreshInterval.description = Interval the device is polled in seconds.
 thing-type.config.omnikinverter.omnik.serial.label = Serial
 thing-type.config.omnikinverter.omnik.serial.description = The serial of the Omnik inverter's Wifi module. This the number part only.
 

diff --git a/bundles/org.openhab.binding.omnikinverter/src/main/resources/OH-INF/thing/thing-types.xml b/bundles/org.openhab.binding.omnikinverter/src/main/resources/OH-INF/thing/thing-types.xml
@@ -103,6 +103,12 @@
 				<label>Serial</label>
 				<description>The serial of the Omnik inverter's Wifi module. This the number part only.</description>
 			</parameter>
+			<parameter name="refreshInterval" type="integer" unit="s" min="5">
+				<label>Refresh Interval</label>
+				<description>Interval the device is polled in seconds.</description>
+				<default>10</default>
+				<advanced>true</advanced>
+			</parameter>
 		</config-description>
 	</thing-type>