[enphase] Review comments

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
openhab · Jan 26, 2021 · d814d2f · d814d2f
1 parent 7a2f122
commit d814d2f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/bundles/org.openhab.binding.enphase/README.md b/bundles/org.openhab.binding.enphase/README.md
@@ -48,12 +48,12 @@ There are channel groups for `production` and `consumption` data.
 The `consumption` data is only available if the gateway reports this.
 A example of a production channel name is: `production#wattsNow`.
 
-| channel            | type          | description            |
-|--------------------|---------------|------------------------|
-| wattHoursToday     | Number:Energy | Watt Hours Today       |
-| wattHoursSevenDays | Number:Energy | Watt Hours Last 7 Days |
-| wattHoursLifetime  | Number:Energy | Watt Hours Lifetime    |
-| wattsNow           | Number:Power  | Watts Now              |
+| channel            | type          | description                           |
+|--------------------|---------------|---------------------------------------|
+| wattHoursToday     | Number:Energy | Watt hours produced today             |
+| wattHoursSevenDays | Number:Energy | Watt hours produced the last 7 days   |
+| wattHoursLifetime  | Number:Energy | Watt hours produced over the lifetime |
+| wattsNow           | Number:Power  | Latest watts produced                 |
 
 The `inverter` thing has the following channels:
 

diff --git a/...nphase/src/main/java/org/openhab/binding/enphase/internal/handler/EnvoyBridgeHandler.java b/...nphase/src/main/java/org/openhab/binding/enphase/internal/handler/EnvoyBridgeHandler.java
@@ -135,6 +135,7 @@ public void initialize() {
         configuration = getConfigAs(EnvoyConfiguration.class);
         if (!EnphaseBindingConstants.isValidSerial(configuration.serialNumber)) {
             updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.CONFIGURATION_ERROR, "Serial Number is not valid");
+            return;
         }
         if (configuration.hostname.isEmpty()) {
             updateStatus(ThingStatus.ONLINE, ThingStatusDetail.CONFIGURATION_PENDING,