Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homematic] gateway extras don't work when a custom id is used #10114

Closed
eikowagenknecht opened this issue Feb 9, 2021 · 4 comments · Fixed by #10131
Closed

[homematic] gateway extras don't work when a custom id is used #10114

eikowagenknecht opened this issue Feb 9, 2021 · 4 comments · Fixed by #10131
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@eikowagenknecht
Copy link
Contributor

Expected Behavior

With OH3 I've started using custom IDs for things (added with the MainUI). The given ID should be used.

Current Behavior

When I do so for the GATEWAY-EXTRAS Thing:

image

it results in:

image

It seems that the only valid value is "GWE00000000". Every other value I tried gives the above error message.

This makes it de facto impossible to use a custom ID when only one name is allowed ;-)

Steps to Reproduce (for Bugs)

See above.

Context

I want to use custom IDs for easier reading of my configuration files.

Your Environment

OH 3.0.1

@eikowagenknecht eikowagenknecht added the bug An unexpected problem or unintended behavior of an add-on label Feb 9, 2021
@MHerbst
Copy link
Contributor

MHerbst commented Feb 12, 2021

Yes, the only valid value currently is "GWE0000000". Because this is a "virtual device" and the binding uses this id to identify the device. Unfortunately, the documentation does not explicitly point this out.

Unfortunately, changing this is quite time-consuming.

@eikowagenknecht
Copy link
Contributor Author

@MHerbst Thanks for looking into it. I've encountered similar issues with several bindings now. Seems like custom IDs are quite often problematic so I'm back to using the mostly cryptic autogenerated IDs again..

So what can we do about that?

  1. Add functionality where a binding can signal to OH core / UI that it needs the default ID to be used. The "custom ID" button is not shown then. > Lots of work
  2. Change all Addons where custom IDs are problematic > Lots of work
  3. Add documentation for the cases where it is problematic. > Easy

I guess we'll stick with 3 then for the time being? I can create a PR against docs if you want.

@MHerbst
Copy link
Contributor

MHerbst commented Feb 12, 2021

@eikowagenknecht I agree. For the time being it's best to simply document it. If I find the time, I would like to do some greater refactorings in the binding. Then I would also try to change this.

I can create a PR against docs if you want.

That would be great

@eikowagenknecht
Copy link
Contributor Author

Allright, it's done :-)

cpmeister pushed a commit that referenced this issue Feb 16, 2021
Fixes #10114

Signed-off-by: Eiko Wagenknecht <eiko.wagenknecht@web.de>
K4ntir4n pushed a commit to K4ntir4n/openhab-addons that referenced this issue Feb 17, 2021
Fixes openhab#10114

Signed-off-by: Eiko Wagenknecht <eiko.wagenknecht@web.de>
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this issue May 10, 2021
Fixes openhab#10114

Signed-off-by: Eiko Wagenknecht <eiko.wagenknecht@web.de>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this issue Nov 7, 2021
Fixes openhab#10114

Signed-off-by: Eiko Wagenknecht <eiko.wagenknecht@web.de>
marcfischerboschio pushed a commit to marcfischerboschio/openHABaddon that referenced this issue Apr 20, 2022
Fixes openhab/openhab-addons#10114

Signed-off-by: Eiko Wagenknecht <eiko.wagenknecht@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants