Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[verisure] Support for non MFA activated user #11228

Closed
jannegpriv opened this issue Sep 8, 2021 · 3 comments
Closed

[verisure] Support for non MFA activated user #11228

jannegpriv opened this issue Sep 8, 2021 · 3 comments
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@jannegpriv
Copy link
Contributor

Verisure has enforced MFA authentication that the binding needs to adapt to.
@jannegpriv jannegpriv added the bug An unexpected problem or unintended behavior of an add-on label Sep 8, 2021
@jannegpriv
Copy link
Contributor Author

Verisure has also changed the authentication process so the binding needs to be adapted to that awell. Also some endpoints used for smartlock and battery status has been removed.

I will work on 2 solutions:

  • Support for new authentication process without having MFA activated on your account
  • Support for MFA

@jannegpriv jannegpriv mentioned this issue Sep 12, 2021
Closed
@jannegpriv
Copy link
Contributor Author

Since Verisure offers the possibility to configure per user if MFA shall be activated or not, it seems more reasonable to only support non MFA activated users for the binding, since this specific user then only can be used for automation and the primary user can then have MFA activated if that is desired.

I will therefore rename this issue to support for non MFA activated users.

@jannegpriv jannegpriv changed the title [verisure] Support for MFA [verisure] Support for non MFA Sep 18, 2021
@jannegpriv jannegpriv changed the title [verisure] Support for non MFA [verisure] Support for non MFA activated user Sep 18, 2021
jannegpriv added a commit to jannegpriv/openhab-addons that referenced this issue Sep 18, 2021
@jannegpriv
[verisure] Adapted to new authentication process and support for non …
2ffcd48 
…MFA acivated user. (openhab#11228)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
jannegpriv added a commit to jannegpriv/openhab-addons that referenced this issue Sep 18, 2021
@jannegpriv
[verisure] Adapted to new authentication process and support for non …
3194ac6 
…MFA activated user. (openhab#11228)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
@jannegpriv jannegpriv mentioned this issue Sep 18, 2021
Merged
jannegpriv added a commit to jannegpriv/openhab-addons that referenced this issue Oct 6, 2021
@jannegpriv
[verisure] Adapted to new authentication process and support for non …
65e5b7d 
…MFA activated user. (openhab#11228)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
lolodomo pushed a commit that referenced this issue Oct 16, 2021
@jannegpriv
[verisure] Adapted to new authentication process and support for non …
18d26aa 
…MFA activated user. (#11228) (#11265)

* [verisure] Adapted to new authentication process and support for non MFA activated user. (#11228)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this issue Oct 26, 2021
@jannegpriv @frederictobiasc
[verisure] Adapted to new authentication process and support for non …
23585a1 
…MFA activated user. (openhab#11228) (openhab#11265)

* [verisure] Adapted to new authentication process and support for non MFA activated user. (openhab#11228)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this issue Nov 9, 2021
@jannegpriv @dschoepel
[verisure] Adapted to new authentication process and support for non …
5b0b175 
…MFA activated user. (openhab#11228) (openhab#11265)

* [verisure] Adapted to new authentication process and support for non MFA activated user. (openhab#11228)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
@wborn
Copy link
Member

wborn commented Dec 18, 2021

Fixed by #11265

@wborn wborn closed this as completed Dec 18, 2021
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this issue Dec 30, 2021
@jannegpriv @NickWaterton
[verisure] Adapted to new authentication process and support for non …
4c787bd 
…MFA activated user. (openhab#11228) (openhab#11265)

* [verisure] Adapted to new authentication process and support for non MFA activated user. (openhab#11228)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this issue Jan 28, 2022
@jannegpriv
[verisure] Adapted to new authentication process and support for non …
2eb6b82 
…MFA activated user. (openhab#11228) (openhab#11265)

* [verisure] Adapted to new authentication process and support for non MFA activated user. (openhab#11228)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this issue May 5, 2022
@jannegpriv
[verisure] Adapted to new authentication process and support for non …
edf6950 
…MFA activated user. (openhab#11228) (openhab#11265)

* [verisure] Adapted to new authentication process and support for non MFA activated user. (openhab#11228)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after code review.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wborn @jannegpriv