Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[surepetcare] Potential issue with transient network connectivity #11527

Closed
dag81 opened this issue Nov 5, 2021 · 0 comments · Fixed by #15411
Closed

[surepetcare] Potential issue with transient network connectivity #11527

dag81 opened this issue Nov 5, 2021 · 0 comments · Fixed by #15411
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@dag81
Copy link
Contributor

dag81 commented Nov 5, 2021

Suspected issue

While working on a new binding using the good work done in surepetcare as a reference point, basically I used the same pattern with the use of the httpClient. This may be dependent on how surepetcare handles its API call's, if uses ongoing http sessions. However, loss of the network routing, meant that call's to the new binding hung. The resolution is to ensure that where request.send() is done, to also include a max timeout such as request.timeout(5, TimeUnit.SECONDS).send(), thus ensuring the http client does not block forever, both the calling thread, or use potentially part of the shared http clients pool of connections. It's probably best if this is added next time, in case they do use or switch to server's that exhibit the same behaviour?

@dag81 dag81 added the bug An unexpected problem or unintended behavior of an add-on label Nov 5, 2021
lsiepel added a commit to lsiepel/openhab-addons that referenced this issue Aug 12, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
wborn pushed a commit that referenced this issue Aug 21, 2023
Fix #11527

* Minor java 17 refactoring
* Spotless

Signed-off-by: lsiepel <leosiepel@gmail.com>
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this issue Sep 29, 2023
Fix openhab#11527

* Minor java 17 refactoring
* Spotless

Signed-off-by: lsiepel <leosiepel@gmail.com>
austvik pushed a commit to austvik/openhab-addons that referenced this issue Mar 27, 2024
Fix openhab#11527

* Minor java 17 refactoring
* Spotless

Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant