You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on a new binding using the good work done in surepetcare as a reference point, basically I used the same pattern with the use of the httpClient. This may be dependent on how surepetcare handles its API call's, if uses ongoing http sessions. However, loss of the network routing, meant that call's to the new binding hung. The resolution is to ensure that where request.send() is done, to also include a max timeout such as request.timeout(5, TimeUnit.SECONDS).send(), thus ensuring the http client does not block forever, both the calling thread, or use potentially part of the shared http clients pool of connections. It's probably best if this is added next time, in case they do use or switch to server's that exhibit the same behaviour?
The text was updated successfully, but these errors were encountered:
dag81
added
the
bug
An unexpected problem or unintended behavior of an add-on
label
Nov 5, 2021
lsiepel
added a commit
to lsiepel/openhab-addons
that referenced
this issue
Aug 12, 2023
Suspected issue
While working on a new binding using the good work done in surepetcare as a reference point, basically I used the same pattern with the use of the httpClient. This may be dependent on how surepetcare handles its API call's, if uses ongoing http sessions. However, loss of the network routing, meant that call's to the new binding hung. The resolution is to ensure that where request.send() is done, to also include a max timeout such as request.timeout(5, TimeUnit.SECONDS).send(), thus ensuring the http client does not block forever, both the calling thread, or use potentially part of the shared http clients pool of connections. It's probably best if this is added next time, in case they do use or switch to server's that exhibit the same behaviour?
The text was updated successfully, but these errors were encountered: