Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gardena] merge automower plugin #13143

Closed
RandomReaper opened this issue Jul 19, 2022 · 4 comments
Closed

[gardena] merge automower plugin #13143

RandomReaper opened this issue Jul 19, 2022 · 4 comments
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@RandomReaper
Copy link

RandomReaper commented Jul 19, 2022

Since the automower plugin share some code with gardena, I think both plugins should be merged.
Husqvarna mowers could be a new Things type (husqvarna_mower?).

Benefits:
bugs like #12980 and #12980 can be handled only once.

@RandomReaper RandomReaper added the enhancement An enhancement or new feature for an existing add-on label Jul 19, 2022
@lolodomo
Copy link
Contributor

Since the automower plugin share some code with gardena

Do you mean they share the same API?

@RandomReaper
Copy link
Author

Since the automower plugin share some code with gardena

Do you mean they share the same API?

They share at least the same account and the login API.

@andrewfg
Copy link
Contributor

They share the same authetication API, but they use quite different API's for the actual functionality.

https://developer.husqvarnagroup.cloud/apis

So I am not convinced that merging these two bindings would make any sense at all.

@andrewfg
Copy link
Contributor

I think that with #13263 the authentication issue of the OP #12980 has been resolved. So I am closing this one now.

@andrewfg andrewfg closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

No branches or pull requests

3 participants