Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automower] Adapt login due to Husqvarna API change #13263

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

crnjan
Copy link
Contributor

@crnjan crnjan commented Aug 14, 2022

The Automower Connect API Authentication does not work anymore as they moved to a new authentication method (AppKey and AppSecret) - adopted.

Fix #12980

Signed-off-by: Boris Krivonog boris.krivonog@inova.si

@crnjan crnjan force-pushed the bugfix/husqvarna_api_auth_change branch from ba4332e to a019a81 Compare August 14, 2022 23:01
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/automower-husqvarna/137401/4

@lolodomo lolodomo added bug An unexpected problem or unintended behavior of an add-on (potentially) not backward compatible labels Aug 15, 2022
@lolodomo
Copy link
Contributor

This is a breaking change as thing parameters are removed/added. To be mentioned in the release notes through a separate PR.

@jlaur
Copy link
Contributor

jlaur commented Aug 15, 2022

For reference: Similar to #13050 (same API change).

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the binding work again! I have found only a small issue with a text.

@crnjan crnjan force-pushed the bugfix/husqvarna_api_auth_change branch from 04de413 to b7fdc09 Compare August 15, 2022 15:27
crnjan added 3 commits August 15, 2022 17:39
…y moved to a new authentication method. (AppKey and AppSecret) - adopted. Fixes issue openhab#12980.

Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
Signed-off-by: Boris Krivonog boris.krivonog@inova.si

Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
Signed-off-by: Boris Krivonog boris.krivonog@inova.si

Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
@crnjan crnjan force-pushed the bugfix/husqvarna_api_auth_change branch from 5a41da4 to 548c426 Compare August 15, 2022 15:39
@jlaur jlaur changed the title [automower] - adaptation of the login due husqvarna api change [automower] Adapt login due to Husqvarna API change Aug 15, 2022
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 0a79b85 into openhab:main Aug 15, 2022
@jlaur jlaur added this to the 3.4 milestone Aug 15, 2022
@jlaur
Copy link
Contributor

jlaur commented Aug 15, 2022

@crnjan - as @lolodomo mentioned, it would be much appreciated if you could create a PR towards the openhab-distro repository with a new section and note for 3.4 about the changed configuration parameter:
https://github.com/openhab/openhab-distro/blob/5635e95a953930c2ef01640b392cb8d2a9af4887/distributions/openhab/src/main/resources/bin/update.lst#L77

Although it's debatable whether it's a breaking change (since the binding was already broken by the API change), it's still a change that users need to make in order to get the binding working again.

@crnjan crnjan deleted the bugfix/husqvarna_api_auth_change branch August 16, 2022 17:34
@crnjan
Copy link
Contributor Author

crnjan commented Aug 17, 2022

@jlaur - created openhab/openhab-distro#1413, fyi.

marcelGoerentz pushed a commit to marcelGoerentz/openhab-addons that referenced this pull request Aug 18, 2022
* The Automower Connect API Authentication does not work anymore as they moved to a new authentication method. (AppKey and AppSecret) - adopted. Fixes issue openhab#12980.

Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
Signed-off-by: Marcel Goerentz <m.goerentz@t-online.de>
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
* The Automower Connect API Authentication does not work anymore as they moved to a new authentication method. (AppKey and AppSecret) - adopted. Fixes issue openhab#12980.

Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* The Automower Connect API Authentication does not work anymore as they moved to a new authentication method. (AppKey and AppSecret) - adopted. Fixes issue openhab#12980.

Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* The Automower Connect API Authentication does not work anymore as they moved to a new authentication method. (AppKey and AppSecret) - adopted. Fixes issue openhab#12980.

Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* The Automower Connect API Authentication does not work anymore as they moved to a new authentication method. (AppKey and AppSecret) - adopted. Fixes issue openhab#12980.

Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* The Automower Connect API Authentication does not work anymore as they moved to a new authentication method. (AppKey and AppSecret) - adopted. Fixes issue openhab#12980.

Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on (potentially) not backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Automower] Binding does not work due to change in Husqvarna API Authentication
4 participants