-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[automower] Adapt login due to Husqvarna API change #13263
Conversation
ba4332e
to
a019a81
Compare
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/automower-husqvarna/137401/4 |
This is a breaking change as thing parameters are removed/added. To be mentioned in the release notes through a separate PR. |
For reference: Similar to #13050 (same API change). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the binding work again! I have found only a small issue with a text.
bundles/org.openhab.binding.automower/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
04de413
to
b7fdc09
Compare
…y moved to a new authentication method. (AppKey and AppSecret) - adopted. Fixes issue openhab#12980. Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
Signed-off-by: Boris Krivonog boris.krivonog@inova.si Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
Signed-off-by: Boris Krivonog boris.krivonog@inova.si Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
5a41da4
to
548c426
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crnjan - as @lolodomo mentioned, it would be much appreciated if you could create a PR towards the openhab-distro repository with a new section and note for 3.4 about the changed configuration parameter: Although it's debatable whether it's a breaking change (since the binding was already broken by the API change), it's still a change that users need to make in order to get the binding working again. |
@jlaur - created openhab/openhab-distro#1413, fyi. |
* The Automower Connect API Authentication does not work anymore as they moved to a new authentication method. (AppKey and AppSecret) - adopted. Fixes issue openhab#12980. Signed-off-by: Boris Krivonog <boris.krivonog@inova.si> Signed-off-by: Marcel Goerentz <m.goerentz@t-online.de>
* The Automower Connect API Authentication does not work anymore as they moved to a new authentication method. (AppKey and AppSecret) - adopted. Fixes issue openhab#12980. Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
* The Automower Connect API Authentication does not work anymore as they moved to a new authentication method. (AppKey and AppSecret) - adopted. Fixes issue openhab#12980. Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
* The Automower Connect API Authentication does not work anymore as they moved to a new authentication method. (AppKey and AppSecret) - adopted. Fixes issue openhab#12980. Signed-off-by: Boris Krivonog <boris.krivonog@inova.si> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
* The Automower Connect API Authentication does not work anymore as they moved to a new authentication method. (AppKey and AppSecret) - adopted. Fixes issue openhab#12980. Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
* The Automower Connect API Authentication does not work anymore as they moved to a new authentication method. (AppKey and AppSecret) - adopted. Fixes issue openhab#12980. Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
The Automower Connect API Authentication does not work anymore as they moved to a new authentication method (AppKey and AppSecret) - adopted.
Fix #12980
Signed-off-by: Boris Krivonog boris.krivonog@inova.si