Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MyBMW] Bridge is not able to connect #14065

Closed
JuergenSmo opened this issue Dec 26, 2022 · 13 comments · Fixed by #14452
Closed

[MyBMW] Bridge is not able to connect #14065

JuergenSmo opened this issue Dec 26, 2022 · 13 comments · Fixed by #14452
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@JuergenSmo
Copy link

Since about two weeks the bridge is not able to connect anymore. Afer enabliing the debug log I get following error message:

2022-12-26 11:34:02.112 [DEBUG] [.internal.handler.MyBMWBridgeHandler] - ###### Discovery Fingerprint Data - BEGIN ######
2022-12-26 11:34:02.114 [DEBUG] [.internal.handler.MyBMWBridgeHandler] - {"url":"https://cocoapi.bmwgroup.com/eadrax-vcs/v1/vehicles?tireGuardMode\u003dENABLED\u0026appDateTime\u003d1672050839283\u0026apptimezone\u003d60","status":500,"reason":"Internal Server Error","params":"{tireGuardMode\u003dtireGuardMode\u003d[ENABLED], appDateTime\u003dappDateTime\u003d[1672050839283], apptimezone\u003dapptimezone\u003d[60]}"}
2022-12-26 11:34:02.115 [DEBUG] [.internal.handler.MyBMWBridgeHandler] - ###### Discovery Fingerprint Data - END ######

image

Expected Behavior

The bridge should be able to connect to the BMW server.

Current Behavior

The brdige try to connect, get the error and switch back to ofline.

Possible Solution

With the BMW app on my mobile phone I am able to connect. I also check the data flow using wireshark but I was not able to see any kind of error in it. The data flow from Openhab looks similar to what the app on the mobile phone is doing.

Steps to Reproduce (for Bugs)

  1. Set the binding to disable
  2. Set the bridge to enable
  3. See the debug log

Context

Without a working bridge the whole binding is of course not working.

Your Environment

Raspberry PI 4B 4 GB mit Raspian Buster and OpenHAB 3.4
@JuergenSmo JuergenSmo added the bug An unexpected problem or unintended behavior of an add-on label Dec 26, 2022
@mherwege
Copy link
Contributor

mherwege commented Dec 26, 2022 •
edited
Loading

More info is available in the forum.
The binding was using some V1 API calls and these do not work anymore. They have to be replaced with V2 calls in the binding code. This also changes all the data transfer formats, so is a major effort. See the forum for discussion of the work on this.

@JuergenSmo
Copy link
Author

@mherwege: Thank you very much. I will follow the forum to see the progress. I am also fine to test.

@jlaur
Copy link
Contributor

jlaur commented Dec 27, 2022

@weymann - FYI.

@martingrassl
Copy link
Contributor

working on it

@pudermueller
Copy link

Same error behaviour in my config.

@sheilbronn
Copy link
Contributor

I am also looking forward to see a fix during the cold weather ;) !
(I'm using the binding to start the car's heating 15 minutes before leaving the house only when outside temperature is not high to prevent frost on the window... ;)
Thanks for your work!

@martingrassl
Copy link
Contributor

Hi, I built the first beta version, you can find more information here: https://community.openhab.org/t/mybmw-binding/130935/139

@JuergenSmo
Copy link
Author

Hi,
many thanks for your work!! The beta is working like a charm for me. I have not yet tested lights and horn bt will do later today. But all the values are back now.

@JuergenSmo
Copy link
Author

Lights and horn also working for me.

@lolodomo
Copy link
Contributor

I would suggest to keep the issue open until a change is proposed and merged.

@JuergenSmo
Copy link
Author

make sense

@JuergenSmo JuergenSmo reopened this Jan 16, 2023
@sheilbronn
Copy link
Contributor

sheilbronn commented Jan 17, 2023 •
edited
Loading

I am also looking forward to see a fix during the cold weather ;) ! (I'm using the binding to start the car's heating 15 minutes before leaving the house only when outside temperature is not high to prevent frost on the window... ;) Thanks for your work!

I can also confirm that lights, honk, and heating (Standheizung) can also be controlled remotely with the new test version! Thanks!

@martingrassl martingrassl mentioned this issue Feb 2, 2023
Closed
@jlaur jlaur linked a pull request Feb 2, 2023 that will close this issue
[mybmw] Fix connected v2 issues #14320
Closed
martingrassl pushed a commit to martingrassl/openhab-addons that referenced this issue Feb 11, 2023
[mybmw] fix not working binding due to API update
d123142 
to make it work the code has been refactored and due to API changes some
improvements could be made. These include:
- (improvement) fingerprint generation: You can
  take a look at the README how to create a
  fingerprint more conveniently.
- (change) changed channel: charge-info has been
  renamed to charge-remaining
- (improvement) added channels:
  estimated-fuel-l-100km and estimated-fuel-mpg
  which calculates the estimated fuel consumption
  based on the range and remaining fuel liters
  - unfortunately such a calculation is not available
  for EVs as there is no information about the capacity of the battery.
- (improvement) added channel last-fetched:
  the last-updated timestamp is showing by when
  the last update of the vehicle happened. As right
  now you can not see from the channels if a thing
  is offline due to connection issues, you can check
  now if last-fetched is more than 5 minutes ago to identify an issue
- (fixed) remote command typos fixed

Co-authored-by: Mark Herwege <mark.herwege@telenet.be>

Fixes openhab#14065

Also-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
@martingrassl martingrassl mentioned this issue Feb 11, 2023
Closed
martingrassl pushed a commit to martingrassl/openhab-addons that referenced this issue Feb 11, 2023
@martingrassl
[mybmw] fix not working binding due to API update
3a4c5e9 
to make it work the code has been refactored and due to API changes some
improvements could be made. These include:
- (improvement) fingerprint generation: You can
  take a look at the README how to create a
  fingerprint more conveniently.
- (change) changed channel: charge-info has been
  renamed to charge-remaining
- (improvement) added channels:
  estimated-fuel-l-100km and estimated-fuel-mpg
  which calculates the estimated fuel consumption
  based on the range and remaining fuel liters
  - unfortunately such a calculation is not available
  for EVs as there is no information about the capacity of the battery.
- (improvement) added channel last-fetched:
  the last-updated timestamp is showing by when
  the last update of the vehicle happened. As right
  now you can not see from the channels if a thing
  is offline due to connection issues, you can check
  now if last-fetched is more than 5 minutes ago to identify an issue
- (fixed) remote command typos fixed

Co-authored-by: Mark Herwege <mark.herwege@telenet.be>

Fixes openhab#14065

Also-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
martingrassl pushed a commit to martingrassl/openhab-addons that referenced this issue Feb 11, 2023
@martingrassl
[mybmw] fix not working binding due to API update
f250535 
to make it work the code has been refactored and due to API changes some
improvements could be made. These include:
- (improvement) fingerprint generation: You can
  take a look at the README how to create a
  fingerprint more conveniently.
- (change) changed channel: charge-info has been
  renamed to charge-remaining
- (improvement) added channels:
  estimated-fuel-l-100km and estimated-fuel-mpg
  which calculates the estimated fuel consumption
  based on the range and remaining fuel liters
  - unfortunately such a calculation is not available
  for EVs as there is no information about the capacity of the battery.
- (improvement) added channel last-fetched:
  the last-updated timestamp is showing by when
  the last update of the vehicle happened. As right
  now you can not see from the channels if a thing
  is offline due to connection issues, you can check
  now if last-fetched is more than 5 minutes ago to identify an issue
- (fixed) remote command typos fixed

Co-authored-by: Mark Herwege <mark.herwege@telenet.be>

Fixes openhab#14065

Also-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
@JuergenSmo
Copy link
Author

fixed with 3.4.2.
Many thanks.

martingrassl pushed a commit to martingrassl/openhab-addons that referenced this issue Feb 19, 2023
@martingrassl
[mybmw] fix not working binding due to API update
f026cd2 
to make it work the code has been refactored and due to API changes some
improvements could be made. These include:
- (improvement) fingerprint generation: You can
  take a look at the README how to create a
  fingerprint more conveniently.
- (change) changed channel: charge-info has been
  renamed to charge-remaining
- (improvement) added channels:
  estimated-fuel-l-100km and estimated-fuel-mpg
  which calculates the estimated fuel consumption
  based on the range and remaining fuel liters
  - unfortunately such a calculation is not available
  for EVs as there is no information about the capacity of the battery.
- (improvement) added channel last-fetched:
  the last-updated timestamp is showing by when
  the last update of the vehicle happened. As right
  now you can not see from the channels if a thing
  is offline due to connection issues, you can check
  now if last-fetched is more than 5 minutes ago to identify an issue
- (fixed) remote command typos fixed

Co-authored-by: Mark Herwege <mark.herwege@telenet.be>

Fixes openhab#14065

Also-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
@martingrassl martingrassl mentioned this issue Feb 19, 2023
Merged
jlaur pushed a commit that referenced this issue Dec 14, 2023
@martingrassl
[mybmw] Upgrade to new BMW API (#14452)
4f84c48 
* [mybmw] fix not working binding due to API update

to make it work the code has been refactored and due to API changes some
improvements could be made. These include:
- (improvement) fingerprint generation: You can
  take a look at the README how to create a
  fingerprint more conveniently.
- (change) changed channel: charge-info has been
  renamed to charge-remaining
- (improvement) added channels:
  estimated-fuel-l-100km and estimated-fuel-mpg
  which calculates the estimated fuel consumption
  based on the range and remaining fuel liters
  - unfortunately such a calculation is not available
  for EVs as there is no information about the capacity of the battery.
- (improvement) added channel last-fetched:
  the last-updated timestamp is showing by when
  the last update of the vehicle happened. As right
  now you can not see from the channels if a thing
  is offline due to connection issues, you can check
  now if last-fetched is more than 5 minutes ago to identify an issue
- (fixed) remote command typos fixed

Fixes #14065

Also-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
austvik pushed a commit to austvik/openhab-addons that referenced this issue Mar 27, 2024
@martingrassl @austvik
[mybmw] Upgrade to new BMW API (openhab#14452)
245825d 
* [mybmw] fix not working binding due to API update

to make it work the code has been refactored and due to API changes some
improvements could be made. These include:
- (improvement) fingerprint generation: You can
  take a look at the README how to create a
  fingerprint more conveniently.
- (change) changed channel: charge-info has been
  renamed to charge-remaining
- (improvement) added channels:
  estimated-fuel-l-100km and estimated-fuel-mpg
  which calculates the estimated fuel consumption
  based on the range and remaining fuel liters
  - unfortunately such a calculation is not available
  for EVs as there is no information about the capacity of the battery.
- (improvement) added channel last-fetched:
  the last-updated timestamp is showing by when
  the last update of the vehicle happened. As right
  now you can not see from the channels if a thing
  is offline due to connection issues, you can check
  now if last-fetched is more than 5 minutes ago to identify an issue
- (fixed) remote command typos fixed

Fixes openhab#14065

Also-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this issue Oct 15, 2024
@martingrassl @joni1993
[mybmw] Upgrade to new BMW API (openhab#14452)
cd2ab00 
* [mybmw] fix not working binding due to API update

to make it work the code has been refactored and due to API changes some
improvements could be made. These include:
- (improvement) fingerprint generation: You can
  take a look at the README how to create a
  fingerprint more conveniently.
- (change) changed channel: charge-info has been
  renamed to charge-remaining
- (improvement) added channels:
  estimated-fuel-l-100km and estimated-fuel-mpg
  which calculates the estimated fuel consumption
  based on the range and remaining fuel liters
  - unfortunately such a calculation is not available
  for EVs as there is no information about the capacity of the battery.
- (improvement) added channel last-fetched:
  the last-updated timestamp is showing by when
  the last update of the vehicle happened. As right
  now you can not see from the channels if a thing
  is offline due to connection issues, you can check
  now if last-fetched is more than 5 minutes ago to identify an issue
- (fixed) remote command typos fixed

Fixes openhab#14065

Also-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
No milestone
7 participants
@lolodomo @jlaur @mherwege @martingrassl @sheilbronn @pudermueller @JuergenSmo