Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Juicenet] Charging State control does not work #15564

Closed
edman007 opened this issue Sep 8, 2023 · 0 comments
Closed

[Juicenet] Charging State control does not work #15564

edman007 opened this issue Sep 8, 2023 · 0 comments
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@edman007
Copy link
Contributor

edman007 commented Sep 8, 2023

Expected Behavior

I'm using the juicenet to control charging. I leave my charger in the default state of "smart" and want to override it by setting it to "start" sometimes, I expect this behavior to work, these are the DSL scripts I'm testing with

JuiceBox_Charger_Charging_State.sendCommand("smart") //or JuiceBox_Charger_Charging_State.sendCommand("start")

Also, in a somewhat related issue, "override" is currently read only, it should be read/write. Specifically setting the charging state sets the new charging state, turning on the override. But to turn it back, it's not correct to change the charging state to what it was because that still overrides the default (and shows as overridden), so you need to be able to remove the override.

Current Behavior

both commands update and appear to work, but it doesn't actually function (nothing happens), and the changes are reverted at the next update

Possible Solution

setOverride() method needs to be fixed, I see typos

override needs an option to disable the override

@edman007 edman007 added the bug An unexpected problem or unintended behavior of an add-on label Sep 8, 2023
edman007 added a commit to edman007/openhab-addons that referenced this issue Sep 8, 2023
 Some obvious typos in setOverride() result in the timestamp being
  ignored which causes it to fail

Fixes openhab#15564

Signed-off-by: Ed Martin <edman007@edman007.com>
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this issue Sep 29, 2023
…enhab#15566)

* [Juicenet] Fix typos in setOverride()
 Some obvious typos in setOverride() result in the timestamp being
  ignored which causes it to fail

Fixes openhab#15564

* [Juicenet] Allow disabling the override
 - The charger has default settings upon plugin, changing the current state
    sets the overide to Y, this makes override settable only in the N direction
    to remove whatever settings were previously applied

* [Juicenet] Document new writable status of override

---------

Signed-off-by: Ed Martin <edman007@edman007.com>
pat-git023 pushed a commit to pat-git023/openhab-addons that referenced this issue Oct 13, 2023
…enhab#15566)

* [Juicenet] Fix typos in setOverride()
 Some obvious typos in setOverride() result in the timestamp being
  ignored which causes it to fail

Fixes openhab#15564

* [Juicenet] Allow disabling the override
 - The charger has default settings upon plugin, changing the current state
    sets the overide to Y, this makes override settable only in the N direction
    to remove whatever settings were previously applied

* [Juicenet] Document new writable status of override

---------

Signed-off-by: Ed Martin <edman007@edman007.com>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this issue Oct 21, 2023
…enhab#15566)

* [Juicenet] Fix typos in setOverride()
 Some obvious typos in setOverride() result in the timestamp being
  ignored which causes it to fail

Fixes openhab#15564

* [Juicenet] Allow disabling the override
 - The charger has default settings upon plugin, changing the current state
    sets the overide to Y, this makes override settable only in the N direction
    to remove whatever settings were previously applied

* [Juicenet] Document new writable status of override

---------

Signed-off-by: Ed Martin <edman007@edman007.com>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this issue Oct 29, 2023
…enhab#15566)

* [Juicenet] Fix typos in setOverride()
 Some obvious typos in setOverride() result in the timestamp being
  ignored which causes it to fail

Fixes openhab#15564

* [Juicenet] Allow disabling the override
 - The charger has default settings upon plugin, changing the current state
    sets the overide to Y, this makes override settable only in the N direction
    to remove whatever settings were previously applied

* [Juicenet] Document new writable status of override

---------

Signed-off-by: Ed Martin <edman007@edman007.com>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this issue Mar 27, 2024
…enhab#15566)

* [Juicenet] Fix typos in setOverride()
 Some obvious typos in setOverride() result in the timestamp being
  ignored which causes it to fail

Fixes openhab#15564

* [Juicenet] Allow disabling the override
 - The charger has default settings upon plugin, changing the current state
    sets the overide to Y, this makes override settable only in the N direction
    to remove whatever settings were previously applied

* [Juicenet] Document new writable status of override

---------

Signed-off-by: Ed Martin <edman007@edman007.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

No branches or pull requests

1 participant