Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hue] Reorganize API/DTO classes #15731

Closed
jlaur opened this issue Oct 10, 2023 · 0 comments · Fixed by #15934
Closed

[hue] Reorganize API/DTO classes #15731

jlaur opened this issue Oct 10, 2023 · 0 comments · Fixed by #15934
Assignees
@jlaur

Comments

@jlaur
Copy link
Contributor

jlaur commented Oct 10, 2023

We could create a subdirectory, internal/api and move the dto directory here as well as serialization.

Additionally, it would be nice to be able to collapse CLIP 1 DTO classes.

So the proposed structure would be something like this:

  • internal/api
    • dto
      • clip1
      • clip2
    • serialization

Originally posted by @jlaur in #15552 (comment)
@jlaur jlaur mentioned this issue Oct 10, 2023
Merged
@jlaur jlaur self-assigned this Nov 20, 2023
jlaur added a commit to jlaur/openhab-addons that referenced this issue Nov 20, 2023
@jlaur
Reorganize API classes
b49178f 
Resolves openhab#15731

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur mentioned this issue Nov 20, 2023
Merged
jlaur added a commit to jlaur/openhab-addons that referenced this issue Nov 20, 2023
@jlaur
Reorganize API classes
afa6a48 
Resolves openhab#15731

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
lolodomo pushed a commit that referenced this issue Nov 25, 2023
@jlaur
Reorganize API classes (#15934)
c7aed14 
Resolves #15731

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Nov 26, 2023
@jlaur @andrewfg
Reorganize API classes (openhab#15934)
a02f048 
Resolves openhab#15731

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
austvik pushed a commit to austvik/openhab-addons that referenced this issue Mar 27, 2024
@jlaur @austvik
Reorganize API classes (openhab#15934)
d6021e7 
Resolves openhab#15731

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlaur jlaur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[hue] Reorganize API classes jlaur/openhab-addons
1 participant
@jlaur