Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freeboxos] Phone / calls: mismatch with default refresh interval #17262

Closed
lolodomo opened this issue Aug 15, 2024 · 3 comments · Fixed by #17272
Closed

[freeboxos] Phone / calls: mismatch with default refresh interval #17262

lolodomo opened this issue Aug 15, 2024 · 3 comments · Fixed by #17272
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@lolodomo
Copy link
Contributor

lolodomo commented Aug 15, 2024

Default is set to 30s for phone while it is set to 2s for calls.
It is the reverse compared to the original binding.
The idea to have the short refresh interval was to detect quickly a phone suddenly ringing. This is a channel on the phone thing. So the short refresh should be on fvs thing type.
There is no hurry to refresh last call.
By the way, the short refresh is interesting only if the ringing channel is linked. So maybe we could have a default refresh set to 30s and the user will reduce it if he links the ringing channel. WDYT @clinique ?

PS: what does "FXS" mean for ? It is too late to change thing type but at least the label of discovered thing should have a label that talks to any user.

@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Aug 15, 2024
@clinique
Copy link
Contributor

This seems to make sense. FXS is the telecom name for fixed line.

@lolodomo
Copy link
Contributor Author

@clinique : did you test the channels for DECT ? It is relatively probable that the "set" API will fail due to convert into enum during "get" (capitalize the value) ? Potential similar problems as already encountered in two other places.
I am not able to test that.

lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Aug 17, 2024
Fix openhab#17262

Also remove the unused class LanlineConfiguration

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
Copy link
Contributor Author

lolodomo commented Aug 17, 2024

@clinique : did you test the channels for DECT ? It is relatively probable that the "set" API will fail due to convert into enum during "get" (capitalize the value) ? Potential similar problems as already encountered in two other places.

These two values (type and network) seem to be provided in lowercase:


14:26:51.454 [DEBUG] [ing.freeboxos.internal.api.ApiHandler] - executeUrl GET: https://mafreebox.freebox.fr:443/api/v12/phone/config
14:26:51.612 [TRACE] [ing.freeboxos.internal.api.ApiHandler] - executeUrl GET - https://mafreebox.freebox.fr:443/api/v12/phone/config returned {"success":true,"result":{"network":"working","dect_eco_mode":false,"dect_pin":"0000","dect_ring_pattern":1,"dect_registration":false,"dect_nemo_mode":false,"dect_enabled":false,"dect_ring_on_off":false}}
14:26:51.619 [DEBUG] [ing.freeboxos.internal.api.ApiHandler] - executeUrl GET: https://mafreebox.freebox.fr:443/api/v12/phone/1
14:26:51.732 [TRACE] [ing.freeboxos.internal.api.ApiHandler] - executeUrl GET - https://mafreebox.freebox.fr:443/api/v12/phone/1 returned {"success":true,"result":{"is_ringing":false,"type":"fxs","id":1,"gain_tx":50,"vendor":"unknown","gain_rx":50,"on_hook":true,"hardware_defect":false,"type_id":1}}

lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Aug 17, 2024
Related to comment in openhab#17262

Signed-oof-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Aug 17, 2024
Related to comment in openhab#17262

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@jlaur jlaur closed this as completed in 22efa53 Aug 17, 2024
jlaur pushed a commit that referenced this issue Aug 18, 2024
Related to comment in #17262

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this issue Aug 29, 2024
Fix openhab#17262

Also remove the unused class LanlineConfiguration

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this issue Aug 29, 2024
Related to comment in openhab#17262

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this issue Sep 29, 2024
Fix openhab#17262

Also remove the unused class LanlineConfiguration

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this issue Sep 29, 2024
Related to comment in openhab#17262

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this issue Oct 15, 2024
Fix openhab#17262

Also remove the unused class LanlineConfiguration

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this issue Oct 15, 2024
Related to comment in openhab#17262

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
matchews pushed a commit to matchews/openhab-addons that referenced this issue Oct 18, 2024
Fix openhab#17262

Also remove the unused class LanlineConfiguration

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
matchews pushed a commit to matchews/openhab-addons that referenced this issue Oct 18, 2024
Related to comment in openhab#17262

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this issue Jan 2, 2025
Fix openhab#17262

Also remove the unused class LanlineConfiguration

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this issue Jan 2, 2025
Related to comment in openhab#17262

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants