-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[freeboxos] Phone / calls: mismatch with default refresh interval #17262
Comments
This seems to make sense. FXS is the telecom name for fixed line. |
@clinique : did you test the channels for DECT ? It is relatively probable that the "set" API will fail due to convert into enum during "get" (capitalize the value) ? Potential similar problems as already encountered in two other places. |
Fix openhab#17262 Also remove the unused class LanlineConfiguration Signed-off-by: Laurent Garnier <lg.hc@free.fr>
These two values (type and network) seem to be provided in lowercase:
|
Related to comment in openhab#17262 Signed-oof-by: Laurent Garnier <lg.hc@free.fr>
Related to comment in openhab#17262 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Related to comment in #17262 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Fix openhab#17262 Also remove the unused class LanlineConfiguration Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Related to comment in openhab#17262 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Fix openhab#17262 Also remove the unused class LanlineConfiguration Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Related to comment in openhab#17262 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Fix openhab#17262 Also remove the unused class LanlineConfiguration Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Related to comment in openhab#17262 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Fix openhab#17262 Also remove the unused class LanlineConfiguration Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Related to comment in openhab#17262 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Fix openhab#17262 Also remove the unused class LanlineConfiguration Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Related to comment in openhab#17262 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Default is set to 30s for phone while it is set to 2s for calls.
It is the reverse compared to the original binding.
The idea to have the short refresh interval was to detect quickly a phone suddenly ringing. This is a channel on the phone thing. So the short refresh should be on fvs thing type.
There is no hurry to refresh last call.
By the way, the short refresh is interesting only if the
ringing
channel is linked. So maybe we could have a default refresh set to 30s and the user will reduce it if he links theringing
channel. WDYT @clinique ?PS: what does "FXS" mean for ? It is too late to change thing type but at least the label of discovered thing should have a label that talks to any user.
The text was updated successfully, but these errors were encountered: