Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pioneeravr] add 2016+ models #7315

Closed
mstormi opened this issue Apr 6, 2020 · 2 comments · Fixed by #7346
Closed

[pioneeravr] add 2016+ models #7315

mstormi opened this issue Apr 6, 2020 · 2 comments · Fixed by #7346
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@mstormi
Copy link
Contributor

mstormi commented Apr 6, 2020

The pioneeravr binding is missing support for AVR models released since 2016.
As the protocol has not changed it is merely a matter of adding products names to a list.

Pinging @gersilex who might be able to author a PR as the original author isn't available.

PioneerAvrBindingConstants.java.txt
@mstormi mstormi added the enhancement An enhancement or new feature for an existing add-on label Apr 6, 2020
gersilex pushed a commit to gersilex/openhab2-addons that referenced this issue Apr 11, 2020
[pioneeravr] add models up until year 2020
ae4bd84 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315
gersilex pushed a commit to gersilex/openhab2-addons that referenced this issue Apr 11, 2020
[PioneerAVR] Add models up until year 2020
430eb5d 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315
gersilex pushed a commit to gersilex/openhab2-addons that referenced this issue Apr 11, 2020
[pioneeravr] Add models up until year 2020
9e49bdb 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315
gersilex pushed a commit to gersilex/openhab2-addons that referenced this issue Apr 11, 2020
[pioneeravr] Add models up until year 2020
8af5d28 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Signed-off-by: Leroy Foerster <gersilex@gmail.com>
@gersilex gersilex mentioned this issue Apr 11, 2020
Merged
gersilex pushed a commit to gersilex/openhab2-addons that referenced this issue Apr 11, 2020
[pioneeravr] Add models up until year 2020
1520411 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
gersilex added a commit to gersilex/openhab2-addons that referenced this issue Apr 11, 2020
@gersilex
[pioneeravr] Add models up until year 2020
7d8fb01 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
gersilex added a commit to gersilex/openhab2-addons that referenced this issue Apr 11, 2020
@gersilex
[pioneeravr] Add models up until year 2020
e6185d5 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
gersilex added a commit to gersilex/openhab2-addons that referenced this issue Apr 12, 2020
@gersilex
[pioneeravr] Add models up until year 2020
4aaadaa 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
@gersilex
Copy link

@mstormi I added the models under the assumption that the features do not differ from the previous models.

Can you please check if it works as expected?

» https://s3.eu-central-1.amazonaws.com/leroy.foerster.it.dienstleistung/org.openhab.binding.pioneeravr-2.5.4-SNAPSHOT.jar

@mstormi
Copy link
Contributor Author

mstormi commented Apr 12, 2020

looks good to me

cpmeister pushed a commit that referenced this issue Apr 15, 2020
@gersilex
[pioneeravr] Add models up until year 2020 (#7346)
55d8f0f 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes #7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
yfre pushed a commit to yfre/openhab-addons that referenced this issue Apr 27, 2020
@gersilex
[pioneeravr] Add models up until year 2020 (openhab#7346)
2f28211 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this issue May 29, 2020
@gersilex @markus7017
[pioneeravr] Add models up until year 2020 (openhab#7346)
af8fda7 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this issue Jun 8, 2020
@gersilex @LoungeFlyZ
[pioneeravr] Add models up until year 2020 (openhab#7346)
7cadde7 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this issue Jul 14, 2020
@gersilex @J-N-K
[pioneeravr] Add models up until year 2020 (openhab#7346)
d604257 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this issue Jul 26, 2020
@gersilex @CSchlipp
[pioneeravr] Add models up until year 2020 (openhab#7346)
1c3dc67 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@gersilex @andrewfg
[pioneeravr] Add models up until year 2020 (openhab#7346)
e0b6de9 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@gersilex @andrewfg
[pioneeravr] Add models up until year 2020 (openhab#7346)
e13aa4e 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@gersilex @andrewfg
[pioneeravr] Add models up until year 2020 (openhab#7346)
f51dcbf 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@gersilex @andrewfg
[pioneeravr] Add models up until year 2020 (openhab#7346)
c02c51e 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this issue Sep 1, 2020
@gersilex @DaanMeijer
[pioneeravr] Add models up until year 2020 (openhab#7346)
38341ee 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this issue Sep 19, 2020
@gersilex @markus7017
[pioneeravr] Add models up until year 2020 (openhab#7346)
b276afa 
Added the models @mstormi provided under the assumption that
the features remained the same since 2015.
The models' functionality remains split and is
easy to enhance with model-year-specific properties later on.

closes openhab#7315

Also-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Leroy Foerster <gersilex@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pioneeravr] Add models up until year 2020 gersilex/openhab2-addons
2 participants
@gersilex @mstormi