Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

|netatmo] Disabling background discovery #8083

Closed
lolodomo opened this issue Jul 6, 2020 · 1 comment
Closed

|netatmo] Disabling background discovery #8083

lolodomo opened this issue Jul 6, 2020 · 1 comment
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@lolodomo
Copy link
Contributor

lolodomo commented Jul 6, 2020

The current behaviour of the binding is a background update of the discovery inbox every time device data is refreshed by calling the Netatmo API.
This could lead to relatively frequent inbox updates (depending on how refresh intervals are setup by the user), just to update timestamps when there are no changes in the user Netatmo setup, and as a consequence this could contribute to accelerate SD card corruption.
Considering we have a manual discovery that could be triggered by the user at any time (using Paper UI) and considering the discovery is generally only helpful when you setup your OH installation, the disadvantage of this background discovery is IMHO bigger than its advantage.
I propose to add a new setting to control this background discovery and to disable this background discovery by default.
@clinique: WDYT ?
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Jul 6, 2020
@clinique
Copy link
Contributor

clinique commented Jul 6, 2020

I completely agree with you

lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Jul 7, 2020
@lolodomo
Add a setting to enable/disable the background discovery
12918c8 
Fix openhab#8083

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Jul 7, 2020
@lolodomo
Add a setting to enable/disable the background discovery
e0113c4 
Fix openhab#8083

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this issue Jul 12, 2020
@lolodomo @knikhilwiz
[netatmo] Null annotations Part 3 of 3 (openhab#8057)
858c5e8 
* [netatmo] Null annotations Part 3 of 3
Fix openhab#7913
* Video status only set when there is a video in the event
* Add a setting to enable/disable the background discovery
Fix openhab#8083
* Cache Optional result in local variable

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this issue Jul 26, 2020
@lolodomo @CSchlipp
[netatmo] Null annotations Part 3 of 3 (openhab#8057)
aa7123f 
* [netatmo] Null annotations Part 3 of 3
Fix openhab#7913
* Video status only set when there is a video in the event
* Add a setting to enable/disable the background discovery
Fix openhab#8083
* Cache Optional result in local variable

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: CSchlipp <christian@schlipp.de>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this issue Aug 3, 2020
@lolodomo @MPH80
[netatmo] Null annotations Part 3 of 3 (openhab#8057)
000fa5b 
* [netatmo] Null annotations Part 3 of 3
Fix openhab#7913
* Video status only set when there is a video in the event
* Add a setting to enable/disable the background discovery
Fix openhab#8083
* Cache Optional result in local variable

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: MPH80 <michael@hazelden.me>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@lolodomo @andrewfg
[netatmo] Null annotations Part 3 of 3 (openhab#8057)
e3e9951 
* [netatmo] Null annotations Part 3 of 3
Fix openhab#7913
* Video status only set when there is a video in the event
* Add a setting to enable/disable the background discovery
Fix openhab#8083
* Cache Optional result in local variable

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@lolodomo @andrewfg
[netatmo] Null annotations Part 3 of 3 (openhab#8057)
921c933 
* [netatmo] Null annotations Part 3 of 3
Fix openhab#7913
* Video status only set when there is a video in the event
* Add a setting to enable/disable the background discovery
Fix openhab#8083
* Cache Optional result in local variable

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@lolodomo @andrewfg
[netatmo] Null annotations Part 3 of 3 (openhab#8057)
5965f85 
* [netatmo] Null annotations Part 3 of 3
Fix openhab#7913
* Video status only set when there is a video in the event
* Add a setting to enable/disable the background discovery
Fix openhab#8083
* Cache Optional result in local variable

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@lolodomo @andrewfg
[netatmo] Null annotations Part 3 of 3 (openhab#8057)
ee97d04 
* [netatmo] Null annotations Part 3 of 3
Fix openhab#7913
* Video status only set when there is a video in the event
* Add a setting to enable/disable the background discovery
Fix openhab#8083
* Cache Optional result in local variable

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this issue Sep 1, 2020
@lolodomo @DaanMeijer
[netatmo] Null annotations Part 3 of 3 (openhab#8057)
150f89a 
* [netatmo] Null annotations Part 3 of 3
Fix openhab#7913
* Video status only set when there is a video in the event
* Add a setting to enable/disable the background discovery
Fix openhab#8083
* Cache Optional result in local variable

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this issue Sep 19, 2020
@lolodomo @markus7017
[netatmo] Null annotations Part 3 of 3 (openhab#8057)
48094ec 
* [netatmo] Null annotations Part 3 of 3
Fix openhab#7913
* Video status only set when there is a video in the event
* Add a setting to enable/disable the background discovery
Fix openhab#8083
* Cache Optional result in local variable

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@clinique clinique linked a pull request Jun 11, 2021 that will close this issue
[Netatmo] Binding rewrite without external dependencies - step 2 #10831
Closed
7 tasks
@clinique clinique removed a link to a pull request Jun 12, 2021
[Netatmo] Binding rewrite without external dependencies - step 2 #10831
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clinique @lolodomo