[modbus] Replace apache commons lang usage with plain java #10002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
ssalonen
added a commit
to ssalonen/openhab2-addons
that referenced
this pull request
Jan 31, 2021
- see also openhab#10002 - I removed equals and hashCode implementation all-together, I could not see they played any role in practice. Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Hilbrand
reviewed
Jan 31, 2021
...inding.modbus/src/main/java/org/openhab/binding/modbus/handler/ModbusPollerThingHandler.java
Show resolved
Hide resolved
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
ssalonen
added a commit
to ssalonen/openhab2-addons
that referenced
this pull request
Feb 1, 2021
- see also openhab#10002 - I removed equals and hashCode implementation all-together, I could not see they played any role in practice. Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Hilbrand
pushed a commit
that referenced
this pull request
Feb 2, 2021
… new-style transformation string (#9945) * [modbus] Cascaded transforms with ∩ * [modbus] README to mention cascaded transformations * [modbus] Take cascaded transformation into use * [modbus] README to show preference towards new syntax * [modbus] examples to use new syntax * [modbus] fix test * [modbus] remove apache commons lang dependency - see also PR #10002 - I removed equals and hashCode implementation all-together, I could not see they played any role in practice. Signed-off-by: Sami Salonen <ssalonen@gmail.com>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Feb 23, 2021
…0002) * [modbus] fix item creation in tests Signed-off-by: Sami Salonen <ssalonen@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Feb 23, 2021
… new-style transformation string (openhab#9945) * [modbus] Cascaded transforms with ∩ * [modbus] README to mention cascaded transformations * [modbus] Take cascaded transformation into use * [modbus] README to show preference towards new syntax * [modbus] examples to use new syntax * [modbus] fix test * [modbus] remove apache commons lang dependency - see also PR openhab#10002 - I removed equals and hashCode implementation all-together, I could not see they played any role in practice. Signed-off-by: Sami Salonen <ssalonen@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…0002) * [modbus] fix item creation in tests Signed-off-by: Sami Salonen <ssalonen@gmail.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
… new-style transformation string (openhab#9945) * [modbus] Cascaded transforms with ∩ * [modbus] README to mention cascaded transformations * [modbus] Take cascaded transformation into use * [modbus] README to show preference towards new syntax * [modbus] examples to use new syntax * [modbus] fix test * [modbus] remove apache commons lang dependency - see also PR openhab#10002 - I removed equals and hashCode implementation all-together, I could not see they played any role in practice. Signed-off-by: Sami Salonen <ssalonen@gmail.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
splatch
pushed a commit
to ConnectorIO/openhab-addons
that referenced
this pull request
Aug 19, 2021
… new-style transformation string (openhab#9945) * [modbus] Cascaded transforms with ∩ * [modbus] README to mention cascaded transformations * [modbus] Take cascaded transformation into use * [modbus] README to show preference towards new syntax * [modbus] examples to use new syntax * [modbus] fix test * [modbus] remove apache commons lang dependency - see also PR openhab#10002 - I removed equals and hashCode implementation all-together, I could not see they played any role in practice. Signed-off-by: Sami Salonen <ssalonen@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…0002) * [modbus] fix item creation in tests Signed-off-by: Sami Salonen <ssalonen@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
… new-style transformation string (openhab#9945) * [modbus] Cascaded transforms with ∩ * [modbus] README to mention cascaded transformations * [modbus] Take cascaded transformation into use * [modbus] README to show preference towards new syntax * [modbus] examples to use new syntax * [modbus] fix test * [modbus] remove apache commons lang dependency - see also PR openhab#10002 - I removed equals and hashCode implementation all-together, I could not see they played any role in practice. Signed-off-by: Sami Salonen <ssalonen@gmail.com>
splatch
pushed a commit
to ConnectorIO/openhab-addons
that referenced
this pull request
Apr 23, 2022
… new-style transformation string (openhab#9945) * [modbus] Cascaded transforms with ∩ * [modbus] README to mention cascaded transformations * [modbus] Take cascaded transformation into use * [modbus] README to show preference towards new syntax * [modbus] examples to use new syntax * [modbus] fix test * [modbus] remove apache commons lang dependency - see also PR openhab#10002 - I removed equals and hashCode implementation all-together, I could not see they played any role in practice. Signed-off-by: Sami Salonen <ssalonen@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…0002) * [modbus] fix item creation in tests Signed-off-by: Sami Salonen <ssalonen@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
… new-style transformation string (openhab#9945) * [modbus] Cascaded transforms with ∩ * [modbus] README to mention cascaded transformations * [modbus] Take cascaded transformation into use * [modbus] README to show preference towards new syntax * [modbus] examples to use new syntax * [modbus] fix test * [modbus] remove apache commons lang dependency - see also PR openhab#10002 - I removed equals and hashCode implementation all-together, I could not see they played any role in practice. Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #7722
After this PR, only Transformation class in modbus uses apache commons lang. I will remove the final references in #9945: 36b45ed
Signed-off-by: Sami Salonen ssalonen@gmail.com