Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Homematic] Removed Apache Commons #10035

Merged
merged 2 commits into from
Feb 8, 2021
Merged

[Homematic] Removed Apache Commons #10035

merged 2 commits into from
Feb 8, 2021

Conversation

MHerbst
Copy link
Contributor

@MHerbst MHerbst commented Feb 2, 2021

This PR completely removes all usages of Apache Commons functions in the Homematic binding.

Related to #7722

It contains the changes from PRs #10027 and #10028

Signed-off-by: Martin Herbst develop@mherbst.de

Signed-off-by: Martin Herbst <develop@mherbst.de>
@MHerbst MHerbst requested a review from gerrieg as a code owner February 2, 2021 19:10
Signed-off-by: Martin Herbst <develop@mherbst.de>
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand merged commit ac02141 into openhab:main Feb 8, 2021
@Hilbrand Hilbrand added this to the 3.1 milestone Feb 8, 2021
@Hilbrand Hilbrand added the enhancement An enhancement or new feature for an existing add-on label Feb 8, 2021
@MHerbst
Copy link
Contributor Author

MHerbst commented Feb 9, 2021

Thx @Hilbrand . That was quick.

themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
Signed-off-by: Martin Herbst <develop@mherbst.de>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
@MHerbst MHerbst deleted the apache-commons branch June 6, 2021 12:17
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
Signed-off-by: Martin Herbst <develop@mherbst.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Signed-off-by: Martin Herbst <develop@mherbst.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants