Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tivo] Add IR code commands to dropdown and documentation #10046

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

mlobstein
Copy link
Contributor

Additional refinement to the revamped Tivo binding. All available IR commands were added to the default drop down for the irCommand channel and to the README. Previously the user was directed to find this info in the protocol PDF which has become harder to find as of late.

@AndyXMB

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@Hilbrand Hilbrand added the enhancement An enhancement or new feature for an existing add-on label Feb 4, 2021
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit da38761 into openhab:main Feb 4, 2021
@cpmeister cpmeister added this to the 3.1 milestone Feb 4, 2021
@mlobstein mlobstein deleted the tivo_ircodes branch February 4, 2021 21:24
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
)

* Add IR code commands to dropdown and documentation
* Add link to community for advanced UI creation

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
)

* Add IR code commands to dropdown and documentation
* Add link to community for advanced UI creation

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
)

* Add IR code commands to dropdown and documentation
* Add link to community for advanced UI creation

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants