Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shelly] Shelly Motion, minor improvements #10054

Merged
merged 7 commits into from
Feb 23, 2021
Merged

[shelly] Shelly Motion, minor improvements #10054

merged 7 commits into from
Feb 23, 2021

Conversation

markus7017
Copy link
Contributor

This PR adds support for Shelly Motion and includes minor improvements

@markus7017
Support for Shelly Motion, some minotr improvements, README updated
e65ac04 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 self-assigned this Feb 4, 2021
@markus7017 markus7017 added the work in progress A PR that is not yet ready to be merged label Feb 4, 2021
@markus7017
minor changes
b2eb107 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 changed the title [shelly][WIP] Shelly Motion, minor improvements [shelly] Shelly Motion, minor improvements Feb 4, 2021
@markus7017 markus7017 added this to the 3.1 milestone Feb 4, 2021
This was linked to issues Feb 4, 2021
[shelly] Color picker doesn't get updated when changed in the Shelly App (RGBW2, Color Bulbs) #9499
Closed
[shelly] Support for Shelly Motion #9506
Closed
@markus7017
Bug fixes from hardening
9790fa2 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 added enhancement An enhancement or new feature for an existing add-on and removed work in progress A PR that is not yet ready to be merged labels Feb 8, 2021
@markus7017
Copy link
Contributor Author

@fwolter reported issues from hardening have been fixed, we are ready for review

@cpmeister cpmeister self-assigned this Feb 9, 2021
@markus7017
review changes applied
6d4f14f 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
Copy link
Contributor Author

@cpmeister changes applied, ready to merge

@markus7017
Copy link
Contributor Author

@cpmeister is there anything open?

@markus7017
review change
ba05a5d 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
Copy link
Contributor Author

@cpmeister change is committed

@markus7017
Copy link
Contributor Author

@cpmeister could we please complete the merge, I already have the next PR ready to submit

@markus7017
Copy link
Contributor Author

@cpmeister anything missing?

@markus7017
Copy link
Contributor Author

@fwolter could you help here? It seems that @cpmeister is pretty busy

@markus7017
review changes, fix creations of sensors#motion and device#externalPower
fb5c96b 
for H%T; moved images/uiroller*.png to doc/images

Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
Copy link
Contributor Author

@fwolter changes committed. I also included a fix for H&T and Motion channel creation

@markus7017
missing in last fix
da5e668 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 linked an issue Feb 23, 2021 that may be closed by this pull request
[shelly] Fix sensors#charger for H&T #10215
Closed
fwolter
fwolter approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There are some checkstyle warnings, which can be fixed easily. Can you do this in some follow-up PR?

@fwolter fwolter merged commit fd1f7eb into openhab:main Feb 23, 2021
@markus7017
Copy link
Contributor Author

@fwolter thanks a lot

@markus7017 markus7017 deleted the shelly_snapshot3.1-2 branch February 23, 2021 17:48
@markus7017
Copy link
Contributor Author

@fwolter

fyi:

[WARNING] org.openhab.binding.shelly.internal.manager.ShellyManagerPage.java:[32]
The package org.apache.commons.io.IOUtils should not be used.

has already be solved

how to fix those warnings?

[WARNING] org.openhab.binding.shelly.internal.provider.ShellyChannelDefinitions.java:[480]
Classes/Interfaces should be annotated with @NonNullByDefault
[WARNING] org.openhab.binding.shelly.internal.provider.ShellyChannelDefinitions.java:[581]
Classes/Interfaces should be annotated with @NonNullByDefault
[WARNING] org.openhab.binding.shelly.internal.manager.ShellyManagerPage.java:[84]
Classes/Interfaces should be annotated with @NonNullByDefault
[WARNING] org.openhab.binding.shelly.internal.manager.ShellyManagerPage.java:[119]
Classes/Interfaces should be annotated with @NonNullByDefault
[WARNING] org.openhab.binding.shelly.internal.manager.ShellyManagerPage.java:[125]
Classes/Interfaces should be annotated with @NonNullByDefault
[WARNING] org.openhab.binding.shelly.internal.manager.ShellyManagerPage.java:[129]
Classes/Interfaces should be annotated with @NonNullByDefault
[WARNING] org.openhab.binding.shelly.internal.manager.ShellyManagerCache.java:[78]
Classes/Interfaces should be annotated with @NonNullByDefault
[WARNING] org.openhab.binding.shelly.internal.coap.ShellyCoapServer.java:[55]
Classes/Interfaces should be annotated with @NonNullByDefault

That refers to inner classes. I know that this check is disabled for *DTO.java, but how to convince the style checker on inner classes in regular class files?

@fwolter
Copy link
Member

fwolter commented Feb 23, 2021

I don't get any of these warnings. Did you run mvn clean install?

themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@markus7017 @themillhousegroup
[shelly] Add Shelly Motion, minor improvements (openhab#10054)
7601c0f 
* Support for Shelly Motion, some minotr improvements, README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* minor changes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Bug fixes from hardening

Signed-off-by: Markus Michels <markus7017@gmail.com>

* review changes applied

Signed-off-by: Markus Michels <markus7017@gmail.com>

* review change

Signed-off-by: Markus Michels <markus7017@gmail.com>

* review changes, fix creations of sensors#motion and device#externalPower
for H%T; moved images/uiroller*.png to doc/images

Signed-off-by: Markus Michels <markus7017@gmail.com>

* missing in last fix

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request May 15, 2021
@markus7017 @lucacalcaterra
[shelly] Add Shelly Motion, minor improvements (openhab#10054)
4230c2e 
* Support for Shelly Motion, some minotr improvements, README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* minor changes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Bug fixes from hardening

Signed-off-by: Markus Michels <markus7017@gmail.com>

* review changes applied

Signed-off-by: Markus Michels <markus7017@gmail.com>

* review change

Signed-off-by: Markus Michels <markus7017@gmail.com>

* review changes, fix creations of sensors#motion and device#externalPower
for H%T; moved images/uiroller*.png to doc/images

Signed-off-by: Markus Michels <markus7017@gmail.com>

* missing in last fix

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@markus7017 @computergeek1507
[shelly] Add Shelly Motion, minor improvements (openhab#10054)
d91dc34 
* Support for Shelly Motion, some minotr improvements, README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* minor changes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Bug fixes from hardening

Signed-off-by: Markus Michels <markus7017@gmail.com>

* review changes applied

Signed-off-by: Markus Michels <markus7017@gmail.com>

* review change

Signed-off-by: Markus Michels <markus7017@gmail.com>

* review changes, fix creations of sensors#motion and device#externalPower
for H%T; moved images/uiroller*.png to doc/images

Signed-off-by: Markus Michels <markus7017@gmail.com>

* missing in last fix

Signed-off-by: Markus Michels <markus7017@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@markus7017 @thinkingstone
[shelly] Add Shelly Motion, minor improvements (openhab#10054)
9812a30 
* Support for Shelly Motion, some minotr improvements, README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* minor changes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Bug fixes from hardening

Signed-off-by: Markus Michels <markus7017@gmail.com>

* review changes applied

Signed-off-by: Markus Michels <markus7017@gmail.com>

* review change

Signed-off-by: Markus Michels <markus7017@gmail.com>

* review changes, fix creations of sensors#motion and device#externalPower
for H%T; moved images/uiroller*.png to doc/images

Signed-off-by: Markus Michels <markus7017@gmail.com>

* missing in last fix

Signed-off-by: Markus Michels <markus7017@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@markus7017
[shelly] Add Shelly Motion, minor improvements (openhab#10054)
78969cf 
* Support for Shelly Motion, some minotr improvements, README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* minor changes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Bug fixes from hardening

Signed-off-by: Markus Michels <markus7017@gmail.com>

* review changes applied

Signed-off-by: Markus Michels <markus7017@gmail.com>

* review change

Signed-off-by: Markus Michels <markus7017@gmail.com>

* review changes, fix creations of sensors#motion and device#externalPower
for H%T; moved images/uiroller*.png to doc/images

Signed-off-by: Markus Michels <markus7017@gmail.com>

* missing in last fix

Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister requested changes

@fwolter fwolter fwolter approved these changes

Assignees

@cpmeister cpmeister

@markus7017 markus7017

Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
3 participants
@markus7017 @fwolter @cpmeister