[miio] GH-9936 Fixed datatype for brightness of the ambient light #10065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ceiling10 Yeelight lamp has 2 dimmer for brightness: "bright" for the main light and bg_bright for the ambient light. Both are of type dimmer and accept percentage values between 1 and 100. This fix changes the datatype of the bg_bright property from Number to Dimmer in the device mapping database file ceiling4, which is also the one that is used for the ceiling10 lamp.
cpmeister
changed the title
marcelrv
reviewed
Feb 7, 2021
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…enhab#10065) The ceiling10 Yeelight lamp has 2 dimmer for brightness: "bright" for the main light and bg_bright for the ambient light. Both are of type dimmer and accept percentage values between 1 and 100. This fix changes the datatype of the bg_bright property from Number to Dimmer in the device mapping database file ceiling4, which is also the one that is used for the ceiling10 lamp. Accepted without sign-off under minor change exemption. Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…enhab#10065) The ceiling10 Yeelight lamp has 2 dimmer for brightness: "bright" for the main light and bg_bright for the ambient light. Both are of type dimmer and accept percentage values between 1 and 100. This fix changes the datatype of the bg_bright property from Number to Dimmer in the device mapping database file ceiling4, which is also the one that is used for the ceiling10 lamp. Accepted without sign-off under minor change exemption.
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…enhab#10065) The ceiling10 Yeelight lamp has 2 dimmer for brightness: "bright" for the main light and bg_bright for the ambient light. Both are of type dimmer and accept percentage values between 1 and 100. This fix changes the datatype of the bg_bright property from Number to Dimmer in the device mapping database file ceiling4, which is also the one that is used for the ceiling10 lamp. Accepted without sign-off under minor change exemption.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ceiling10 Yeelight lamp has 2 dimmer for brightness:
"bright" for the main light and bg_bright for the ambient light.
Both are of type dimmer and accept percentage values between 1 and 100.
This fix changes the datatype of the bg_bright property from Number
to Dimmer in the device mapping database file ceiling4, which is also
the one that is used for the ceiling10 lamp.