-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tankerkoenig] Lower minimum refresh interval #10070
Conversation
As per https://creativecommons.tankerkoenig.de (in the "Terms"-section) we should not make more than 1 request per 5 minutes, this changes the limit accordingly and allows doing so. Signed-off-by: Flole <flole@flole.de>
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say this was based on the idea 2 api calls are made: getStationListData
and getStationDetailData
. the latter one is only made once a day. So it's probably save to make a call every 5 minutes.
Thanks for the Merge and No, the DetailRequest isn't counted in that sense (once a day IOT get changes in the opening time schedule). |
As per https://creativecommons.tankerkoenig.de (in the "Terms"-section) we should not make more than 1 request per 5 minutes, this changes the limit accordingly and allows doing so. Signed-off-by: Flole <flole@flole.de> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
As per https://creativecommons.tankerkoenig.de (in the "Terms"-section) we should not make more than 1 request per 5 minutes, this changes the limit accordingly and allows doing so. Signed-off-by: Flole <flole@flole.de>
As per https://creativecommons.tankerkoenig.de (in the "Terms"-section) we should not make more than 1 request per 5 minutes, this changes the limit accordingly and allows doing so. Signed-off-by: Flole <flole@flole.de>
As per https://creativecommons.tankerkoenig.de (in the "Terms"-section) we should not make more than 1 request per 5 minutes, this changes the limit accordingly and allows doing so.