Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tankerkoenig] Lower minimum refresh interval #10070

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Conversation

Flole998
Copy link
Member

@Flole998 Flole998 commented Feb 6, 2021

As per https://creativecommons.tankerkoenig.de (in the "Terms"-section) we should not make more than 1 request per 5 minutes, this changes the limit accordingly and allows doing so.

As per https://creativecommons.tankerkoenig.de (in the "Terms"-section) we should not make more than 1 request per 5 minutes, this changes the limit accordingly and allows doing so.

Signed-off-by: Flole <flole@flole.de>
@Flole998 Flole998 requested a review from JueBag as a code owner February 6, 2021 16:51
@JueBag
Copy link

JueBag commented Feb 6, 2021

LGTM
Can't remember if the explizit limit of 5 minutes was stated when the binding was created or if I used 10 minutes to be on the safe side.

Copy link
Contributor

@Skinah Skinah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand added the enhancement An enhancement or new feature for an existing add-on label Feb 8, 2021
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say this was based on the idea 2 api calls are made: getStationListData and getStationDetailData. the latter one is only made once a day. So it's probably save to make a call every 5 minutes.

@Hilbrand Hilbrand merged commit c01f5ce into openhab:main Feb 8, 2021
@Hilbrand Hilbrand added this to the 3.1 milestone Feb 8, 2021
@JueBag
Copy link

JueBag commented Feb 9, 2021

I would say this was based on the idea 2 api calls are made: getStationListData and getStationDetailData. the latter one is only made once a day. So it's probably save to make a call every 5 minutes.

Thanks for the Merge and No, the DetailRequest isn't counted in that sense (once a day IOT get changes in the opening time schedule).

themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
As per https://creativecommons.tankerkoenig.de (in the "Terms"-section) we should not make more than 1 request per 5 minutes, this changes the limit accordingly and allows doing so.

Signed-off-by: Flole <flole@flole.de>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
@wborn wborn changed the title [Tankerkoenig]: Lower minimum refresh interval [Tankerkoenig] Lower minimum refresh interval Jun 22, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
As per https://creativecommons.tankerkoenig.de (in the "Terms"-section) we should not make more than 1 request per 5 minutes, this changes the limit accordingly and allows doing so.

Signed-off-by: Flole <flole@flole.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
As per https://creativecommons.tankerkoenig.de (in the "Terms"-section) we should not make more than 1 request per 5 minutes, this changes the limit accordingly and allows doing so.

Signed-off-by: Flole <flole@flole.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants