[homekit] min and max temperature units according to useFahrenheitTemperature #10074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re setting Signed-off-by: Eugen Freiter <freiter@gmx.de>
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…tTemperature setting (openhab#10074) Signed-off-by: Eugen Freiter <freiter@gmx.de> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…tTemperature setting (openhab#10074) Signed-off-by: Eugen Freiter <freiter@gmx.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…tTemperature setting (openhab#10074) Signed-off-by: Eugen Freiter <freiter@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make min/max values for current and target temperatures according to useFahrenheitTemperature settings.
HomeKit protocol works internally always with Celsius. So that we need to convert all temperatures to Celsius as well.
convertToCelsius method considers the useFahrenheitTemperature and if it is set to true, it converts from Fahrenheit to Celsius
this PR partially fixes #9538.
the missing part is HeatingThresholdTemperature and CoolingThresholdTemperature. A fix for them requires some refactoring of HomekitCharacteristicFactory as it has no access to settings. It will done in a separate PR.
Signed-off-by: Eugen Freiter freiter@gmx.de