Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homekit] make use of openHAB mDNS service #10076

Merged
merged 5 commits into from
Feb 25, 2021
Merged

Conversation

yfre
Copy link
Contributor

@yfre yfre commented Feb 6, 2021

  • make use of openHAB mDNS service instead of creating a new separate mDNS instance only for Homekit maybe it will solve [homekit] Binding stops working after a couple of days #9773.
  • remove use of IP address configuration as it cannot be used with Java-HAP if mDNS service is provided
  • remove global settings for minimum and maximum temperature. They are not used anymore and also were not mentioned in the binding documentation. Instead of global min/max can be set now at item level.

Signed-off-by: Eugen Freiter freiter@gmx.de

Eugen Freiter added 2 commits February 6, 2021 22:50
Signed-off-by: Eugen Freiter <freiter@gmx.de>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
@Hilbrand Hilbrand added the bug An unexpected problem or unintended behavior of an add-on label Feb 8, 2021
@cpmeister cpmeister self-assigned this Feb 9, 2021
Signed-off-by: Eugen Freiter <freiter@gmx.de>
@yfre
Copy link
Contributor Author

yfre commented Feb 15, 2021

i checked and it is not that easy to have multiple HomeKit bridges or one bridge bound to multiple IP address / mDNS services. the main limitation is the Java-HAP library.

i implemented the first option:

  • i have add networkInterface configuration back
  • if networkInterface is not set, HomeKit addon will take first configured openHAB mDNS client
  • if networkInterface is configured, HomeKit addon will try to find existing openHAB mDNS client for this address and reuse. if there none, it will create a new one as it did in the past

i have also added a section with troubleshooting for network connection to README

@cpmeister please review

Eugen Freiter added 2 commits February 16, 2021 00:46
Signed-off-by: Eugen Freiter <freiter@gmx.de>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
@yfre yfre requested a review from cpmeister February 21, 2021 20:41
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 23ff9a0 into openhab:main Feb 25, 2021
@cpmeister cpmeister added this to the 3.1 milestone Feb 25, 2021
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-3-1-milestone-discussion/116025/52

themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
* make use of openHAB mdns service
* remove unnecessary null check
* add network configuration back

Signed-off-by: Eugen Freiter <freiter@gmx.de>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/homekit-no-longer-functioning/34580/21

computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
* make use of openHAB mdns service
* remove unnecessary null check
* add network configuration back

Signed-off-by: Eugen Freiter <freiter@gmx.de>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
* make use of openHAB mdns service
* remove unnecessary null check
* add network configuration back

Signed-off-by: Eugen Freiter <freiter@gmx.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* make use of openHAB mdns service
* remove unnecessary null check
* add network configuration back

Signed-off-by: Eugen Freiter <freiter@gmx.de>
@yfre yfre deleted the mdns_service branch November 15, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants