-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[homekit] make use of openHAB mDNS service #10076
Conversation
Signed-off-by: Eugen Freiter <freiter@gmx.de>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitImpl.java
Show resolved
Hide resolved
Signed-off-by: Eugen Freiter <freiter@gmx.de>
i checked and it is not that easy to have multiple HomeKit bridges or one bridge bound to multiple IP address / mDNS services. the main limitation is the Java-HAP library. i implemented the first option:
i have also added a section with troubleshooting for network connection to README @cpmeister please review |
Signed-off-by: Eugen Freiter <freiter@gmx.de>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-3-1-milestone-discussion/116025/52 |
* make use of openHAB mdns service * remove unnecessary null check * add network configuration back Signed-off-by: Eugen Freiter <freiter@gmx.de> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/homekit-no-longer-functioning/34580/21 |
* make use of openHAB mdns service * remove unnecessary null check * add network configuration back Signed-off-by: Eugen Freiter <freiter@gmx.de>
* make use of openHAB mdns service * remove unnecessary null check * add network configuration back Signed-off-by: Eugen Freiter <freiter@gmx.de>
* make use of openHAB mdns service * remove unnecessary null check * add network configuration back Signed-off-by: Eugen Freiter <freiter@gmx.de>
Signed-off-by: Eugen Freiter freiter@gmx.de