Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deconz] Use system default channel types for lights #10126

Merged

Conversation

cweitkamp
Copy link
Contributor

  • Use system default channel types for lights

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp added the enhancement An enhancement or new feature for an existing add-on label Feb 11, 2021
@@ -24,19 +24,6 @@
<config-description-ref uri="thing-type:deconz:sensor"/>
</thing-type>

<channel-type id="alert">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This channel type is a duplicate and defined in light-thing-types.xml too.

@J-N-K
Copy link
Member

J-N-K commented Feb 11, 2021

I veto that. It changes the visibility of channels and thus confuses users.

@cweitkamp
Copy link
Contributor Author

You mean the ColorTemperatur? I forgot about that.

Would you agree if I exclude it from this PR?

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/zigbee-binding/15763/2416

@wborn wborn added this to the 3.1 milestone Mar 21, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
* Use system default channel types for lights

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
* Use system default channel types for lights

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* Use system default channel types for lights

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants