[OmniLink] Fix OmniLink temperature/humidity sensors #10130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye
added
the
external bug
|
Can you edit your first post to give why you are doing the fix? what symptoms? why is it needed? Someone may do a review that may not have the hardware and they will need some context and also it goes into the release notes that all users may click on to read the details. |
|
I‘m no longer part of the maintainer group, so: no. |
I'm sorry that it came to this. Thanks for all your contributions to this project over the past couple of years. Wishing you the best for the future! |
K4ntir4n
pushed a commit
to K4ntir4n/openhab-addons
that referenced
this pull request
Feb 17, 2021
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
Signed-off-by: Ethan Dye <mrtops03@gmail.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream code the allows connection to the OmniPro uses float values to convert into Omni values, therefore this change was necessary to allow for proper execution of setting temperature commands.
Signed-off-by: Ethan Dye mrtops03@gmail.com